-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator: WithLatestFrom #2760
Merged
Merged
Operator: WithLatestFrom #2760
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
src/main/java/rx/internal/operators/OperatorWithLatestFrom.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
/** | ||
* Copyright 2014 Netflix, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
* use this file except in compliance with the License. You may obtain a copy of | ||
* the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations under | ||
* the License. | ||
*/ | ||
package rx.internal.operators; | ||
|
||
import java.util.concurrent.atomic.AtomicReference; | ||
|
||
import rx.*; | ||
import rx.Observable.Operator; | ||
import rx.functions.Func2; | ||
import rx.observers.SerializedSubscriber; | ||
|
||
/** | ||
* Combines values from two sources only when the main source emits. | ||
* @param <T> the element type of the main observable | ||
* @param <U> the element type of the other observable that is merged into the main | ||
* @param <R> the result element type | ||
*/ | ||
public final class OperatorWithLatestFrom<T, U, R> implements Operator<R, T> { | ||
final Func2<? super T, ? super U, ? extends R> resultSelector; | ||
final Observable<? extends U> other; | ||
/** Indicates the other has not yet emitted a value. */ | ||
static final Object EMPTY = new Object(); | ||
|
||
public OperatorWithLatestFrom(Observable<? extends U> other, Func2<? super T, ? super U, ? extends R> resultSelector) { | ||
this.other = other; | ||
this.resultSelector = resultSelector; | ||
} | ||
@Override | ||
public Subscriber<? super T> call(Subscriber<? super R> child) { | ||
// onError and onCompleted may happen either from the main or from other. | ||
final SerializedSubscriber<R> s = new SerializedSubscriber<R>(child, false); | ||
child.add(s); | ||
|
||
final AtomicReference<Object> current = new AtomicReference<Object>(EMPTY); | ||
|
||
final Subscriber<T> subscriber = new Subscriber<T>(s, true) { | ||
@Override | ||
public void onNext(T t) { | ||
Object o = current.get(); | ||
if (o != EMPTY) { | ||
try { | ||
@SuppressWarnings("unchecked") | ||
U u = (U)o; | ||
R result = resultSelector.call(t, u); | ||
|
||
s.onNext(result); | ||
} catch (Throwable e) { | ||
onError(e); | ||
return; | ||
} | ||
} | ||
} | ||
@Override | ||
public void onError(Throwable e) { | ||
s.onError(e); | ||
s.unsubscribe(); | ||
} | ||
@Override | ||
public void onCompleted() { | ||
s.onCompleted(); | ||
s.unsubscribe(); | ||
} | ||
}; | ||
|
||
Subscriber<U> otherSubscriber = new Subscriber<U>() { | ||
@Override | ||
public void onNext(U t) { | ||
current.set(t); | ||
} | ||
@Override | ||
public void onError(Throwable e) { | ||
s.onError(e); | ||
s.unsubscribe(); | ||
} | ||
@Override | ||
public void onCompleted() { | ||
if (current.get() == EMPTY) { | ||
s.onCompleted(); | ||
s.unsubscribe(); | ||
} | ||
} | ||
}; | ||
s.add(subscriber); | ||
s.add(otherSubscriber); | ||
|
||
other.unsafeSubscribe(otherSubscriber); | ||
|
||
return subscriber; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming this "resultSelector" seems off (copy/paste?) since it's more akin to
combineLatest
which uses "combineFunction".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RxJS has this so I kept the naming. (Our
flatMap
andgroupJoin
useresultSelector
as well).