Add option to modify the number of cores #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #126, the emulator being set up by
avdmanager
in the new command-line tools only uses 1 core, which affects the stability of the emulator negatively sometimes.In our experience, 2 cores seem to be pretty solid with no (or almost no) System UI ANR dialogs being shown on boot.
Appending a new line with a duplicate
hw.cpu.ncore
overrides other lines defining the same property before it.Please let me know if you'd like me to add this option in
workflow.yml
file as well so that the tests include this option as well. Wasn't sure about updating that.