refactor(threads): error monitor spawned threads

[zsoerenm]

Spawned threads should be error monitored, because any error that is thrown inside the thread will silently be discarded otherwise.

[bvdmitri]

Hey @zsoerenm ! Thanks, I think the change is reasonable, however, the Base.errormonitor is not available for example in Julia 1.6, so the new code might fail on the old Julia versions. This is something we wish to avoid. Could you please double-check which version introduced the Base.errormonitor and add a @static if to prevent using it on the older versions of Julia.

[bvdmitri]

Here is the list of supported versions https://github.com/biaslab/Rocket.jl/actions/runs/5998363534

[zsoerenm]

Good point. I added a static version check.
It was added with v1.7 (see JuliaLang/julia@754aada)

[bvdmitri]

Thanks!