feat(YouTube - Settings): Add icons to the ReVanced settings

[MarcaDian]

After

[LisoUseInAIKyrios]

The YouTube brand guidelines does not mention Shorts or the Shorts logo, so it's unclear if permission is needed to use a Shorts icon.

https://www.youtube.com/howyoutubeworks/resources/brand-resources

[MarcaDian]

I took the Shorts icon from some site and edited it to size. It is not in the Google icon repository. In fact, it is custom icon.

[LisoUseInAIKyrios]

Their brand guidelines apply to custom graphics as well. The question is if the Shorts logo needs permission to use.

[MarcaDian]

I think it's better to add Copyright than to decide if it is necessary or not.

[LisoUseInAIKyrios]

https://en.m.wikipedia.org/wiki/File:Youtube_shorts_icon.svg

Wikipedia lists the vector icon file as public domain, but with a caution that it might be trademarked.

Searching the USPTO website shows that "YouTube Shorts" is trademarked:
https://tsdr.uspto.gov/#caseNumber=90980684&caseSearchType=US_APPLICATION&caseType=DEFAULT&searchType=statusSearch
https://tsdr.uspto.gov/#caseNumber=90313243&caseSearchType=US_APPLICATION&caseType=DEFAULT&searchType=statusSearch

But the trademark does not include a wordmark or logo. For reference the YouTube logo and wordmark is trademarked

So, maybe it's ok to modify and use the public domain vector icon.

[kitadai31]

Can't it depend on the app's native icon resources?
@drawable/yt_outline_youtube_shorts_black_24 and @drawable/yt_outline_youtube_shorts_white_24 exist

[LisoUseInAIKyrios]

If that built in icon matches the line width of the other icons (or the other icons can be adjusted to match the built in icon), then using that would be best.

But I think using the icon already here might be ok too

[MarcaDian]

If necessary, it is also possible to add icons to the submenus, but it seems to me that this goes beyond the design code of the YouTube settings.

Although, for example, hiding buttons for the user would be intuitive as to which button would be hidden.

[LisoUseInAIKyrios]

I think icons for only some submenu items but not for other items would look out of place.

The hide action and navigation buttons are the only settings that an icon might help, but I think it's easy to understand what those settings do just from the setting title text.

[MarcaDian]

What if change Shorts icon to this. I also made some another variants.
I think it's better not to risk, it's just an icon in settings, and even a branded icon doesn't show the essence of this setting.

[LisoUseInAIKyrios]

Looks good, but maybe remove the gear icon. The Shorts settings are less like the video settings and more like the player (which has no gear).

[MarcaDian]

but maybe remove the gear icon

Ok, it was a second variant =)

[LisoUseInAIKyrios]

https://fonts.google.com/icons?icon.size=24&icon.color=%23e8eaed&icon.query=video&selected=Material+Symbols+Outlined:animated_images:FILL@0;wght@200;GRAD@0;opsz@24&icon.platform=web

The animated images you suggested also looks ok.

[MarcaDian]

animated images

But it is not available in the GitHub repository... Found

[oSumAtrIX]

There's multiple considerations with this PR

• The icons don't comply with the design language of YouTube settings
• If the design language is broken, then break it as little as possible and use the icon set used in the design language, no custom icons
• Trademarked icons like the Shorts icon are probably fine. Maybe there's a way to request rights, similar to how we did it for the YouTube logo on our website and GitHub organization readme. Maybe certain usage doesn't require rights, such as free-use

[MarcaDian]

I tried to choose icons more appropriate to the context of the menu item.
But not all necessary icons are in the Google icon library. In any case, if anyone don't like them, can turn them off in the settings.
Perhaps someone has suggestions to change some unsuitable icon.

But IMHO, at the moment, Google has a poor taste in the design code in the YouTube settings, some icons are simply terrible.

[LisoUseInAIKyrios]

These icons could be default off, so users need to opt in to see them.