fix(YouTube): Do not hide player controls when using double tap to skip forward

[LisoUseInAIKyrios]

Follow up fix to #4469

The prior fix could cause the player controls to permanently disappear if the screen is tapped while a fade out animation is running.

[MarcaDian]

What if use an invisible placeholder in the xml of each button? I will try this option now.

[LisoUseInAIKyrios]

I tried using animation listeners and set the buttons to GONE after the animation finishes, but it has issues with the buttons flickering and fading in/out inappropriately when tapping rapidly.

[MarcaDian]

MarcaDian@d20c487

I haven't checked this commit yet, I'm running out of time.
I previously wanted to implement this as a second solution.
That is, the animations remains as it was, but during the animation of the button's disappearance, there will be a placeholder under it, which prevents the chapter title from climbing onto the button.

[LisoUseInAIKyrios]

If a button is turned off in the settings while a video is open, then the placeholder is not set hidden and a blank space is kept.

Needs a minor adjustment to fix that otherwise this seems to work.

[MarcaDian]

MarcaDian@ae9ee2d ? I think that fixes it

The disabled buttons disappear after tapping the screen after restoring from the miniplayer.

[MarcaDian]

Only one small bug remains, if you tap on the screen and immediately swipe to the miniplayer, and then expand it, the buttons keep fading animation.
This is so ridiculous that it probably doesn't need fixing.
But it is possible to cause cleaning after changing the state of the player.
Is it necessary?

Screenrecorder-2025-02-22-00-02-36-656.mp4

[MarcaDian]

Only one small bug remains, if you tap on the screen and immediately swipe to the miniplayer, and then expand it, the buttons keep fading animation.

Probably fix by MarcaDian@9094c8b
More tests are needed, but for now everything works as it should for me

[LisoUseInAIKyrios]

It seems to be working now. I cannot reproduce any issues when entering/exiting fullscreen, so I'm unsure if MarcaDian@9094c8b is needed.

[MarcaDian]

entering/exiting fullscreen

Miniplayer?

[LisoUseInAIKyrios]

Actually, maximizing from miniplayer can incorrectly show the buttons for a moment.

Will incorporate later today MarcaDian@9094c8b

[LisoUseInAIKyrios]

I could only reproduce the miniplayer button visibility issue once, but I don't remember if the fullscreen button was also visible (if fullscreen was visible then it was not a bug and was the correct behavior).

I will try a bit more and see if the issue can be reproduced with what's currently here.

[MarcaDian]

if the fullscreen button was also visible

Only the RV buttons were visible to me, see video above

[LisoUseInAIKyrios]

Did you try with this PR? If you can reproduce then I'll integrate MarcaDian@9094c8b

[MarcaDian]

Did you try with this PR?

Just tried it now.

Before

After

[LisoUseInAIKyrios]

@MarcaDian any issues remaining? I think this is ready.

[MarcaDian]

I used it for about an hour, I did not notice any bugs. Probably ready

[MarcaDian]

😮‍💨 it feels like it will never end

Now

5.12.0

[LisoUseInAIKyrios]

Try adding this snippet back again:

ec89649

protected void setVisibilityImmediate(boolean visible) {
        if (visible) {
            Utils.runOnMainThread(() -> private_setVisibility(true, false));
        } else {
            private_setVisibility(false, false);
        }

[MarcaDian]

That's the first thing I thought, I'll have to try it later. 👌

[MarcaDian]

Try adding this snippet back again:

This solved the problem.

[LisoUseInAIKyrios]

Make a PR with the change