Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update to patcher v22 #4409

Open
wants to merge 100 commits into
base: dev
Choose a base branch
from
Open

feat: Update to patcher v22 #4409

wants to merge 100 commits into from

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Feb 3, 2025 •
edited
Loading

Initial usage of Patcher v22 method instruction filters.

ReVanced/revanced-patcher#329

@LisoUseInAIKyrios
refactor: Basic use of patcher v22 instruction filters
bf83db8
@LisoUseInAIKyrios
refactor
6111bca
@LisoUseInAIKyrios
refactor
f9767e1
@LisoUseInAIKyrios
fix: add missing dependency used by fingerprints
96e60a4
@LisoUseInAIKyrios
refactor: use 'by' semantic
cfce280
@LisoUseInAIKyrios
Allow using a fingerprint result inside another fingerprint
2d1f7ff
@LisoUseInAIKyrios
refactor
5c3fb65
@LisoUseInAIKyrios
use non deprecated method
3db7566
@LisoUseInAIKyrios
Simplify
f3b8602
@LisoUseInAIKyrios
refactor: Simplify with class (parent) fingerprint
d2fbbf5
@LisoUseInAIKyrios
refactor
37833a0
@LisoUseInAIKyrios
use NewInstanceFilter filter
0dfa503
@LisoUseInAIKyrios
fix version constrain
adc89a6
@LisoUseInAIKyrios
refactor
e823574
@LisoUseInAIKyrios
Restore use of context receivers
2c1cdcc 
This reverts commit f3b8602.
@LisoUseInAIKyrios
refactor: Rename to MethodCallFilter and FieldCallFilter
d44f860
@LisoUseInAIKyrios
Revert "refactor: Simplify with class (parent) fingerprint"
7ca1542 
This reverts commit d2fbbf5.
@LisoUseInAIKyrios
refactor: Rename FieldCallFilter -> FieldAccessFilter
d270192
@LisoUseInAIKyrios
Merge remote-tracking branch 'upstream/dev' into feat/patcher_instruc…
e0d97f4 
…tion_filters
@LisoUseInAIKyrios
refactor: Use DSL style constructor functions
8114617
@LisoUseInAIKyrios
refactor: Use String literal instruction filter
dfd6149
@LisoUseInAIKyrios
refactor
d2900b7
@LisoUseInAIKyrios
simplify
41f753e
@LisoUseInAIKyrios
vastly simplify
0277624
@LisoUseInAIKyrios
refactor: Match class types using endsWith
676991a
@LisoUseInAIKyrios
unofficial 20.02
d293cdd
@LisoUseInAIKyrios
refactor
1802d00
@LisoUseInAIKyrios
Merge remote-tracking branch 'upstream/dev' into feat/patcher_instruc…
ce7613f 
…tion_filters
@LisoUseInAIKyrios
Merge remote-tracking branch 'upstream/dev' into feat/patcher_instruc…
8a9c5ab 
…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/youtube/video/speed/custom/CustomPlaybackSpeedPatch.kt
@LisoUseInAIKyrios
Merge remote-tracking branch 'upstream/dev' into feat/patcher_instruc…
c57ad58 
…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/fix/cairo/DisableCairoSettingsPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/fix/cairo/Fingerprints.kt
@cyberboh
Copy link

@LisoUseInAIKyrios Dislikes tiny bug finally fixed in 20.07.37.
Also, this PR can be used to patch 20.08.32 successfully which is recently released. Personally tested. 👍

@0xrxL
Copy link

0xrxL commented Feb 20, 2025

I was thinking that maybe it would be useful to create a specific (and always open) PR like this, related to new YouTube versions adaptation. This would help to avoid two situations:

  1. Possible unwanted A/B tests.
  2. Many patches broken in one time, caused by the ignored new stock versions released (like switching from 19.25 to 19.47 for example).

@LisoUseInAIKyrios
Copy link
Contributor Author

@0xrxL it's simpler to fix new versions using refactor/chore commits such as #4179 and users who care can turn off version checks and patch using dev/main releases.

The changes have been here to test out the patcher changes and because some of the fingerprints changes got too complicated to use without the patcher changes (one in particular would have needed 4 different fingerprints, and here it's a single fingerprint).

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/patcher_instruction_filters branch from 79d8f33 to 010f876 Compare February 20, 2025 10:34
@cyberboh
Copy link

20.07 seems a little buggy. The dislikes text looks wrong (text is too large, and might be using the wrong font), and it's like that unpatched. Maybe they changed the text intentionally but it doesn't look right.

I've been using 20.06 and encountered no issues.

Seem this is caused by RYD patch is not compatible with 20.07+.
My conclusion above is based on my test:

  1. 20.07+ patched with default patches, disable spoof streams, restart app, RYD is buggy.
  2. Then cleared data 20.07+ , RYD is normal, but after tick untick any options that need restart the app, issue is back.
  3. 20.06 is normal, even i tick untick and restart the app many times. Tested in 20.06.42

@LisoUseInAIKyrios
Copy link
Contributor Author

What bugs are referring to? The only bug I find is the text font looks wrong and the vertical alignment is not quite right. Both issues are present with 20.07+ with and without RYD enabled. I don't experience any other issues.

@cyberboh
Copy link

cyberboh commented Feb 20, 2025 •
edited
Loading

Yes i mean the text issue is not fit to the likes dislikes button.
I just patched with default patches, and think this is caused by RYD.
If the issue is not caused by RYD, maybe caused by another patch or Google add some more A/B flags.

@LisoUseInAIKyrios
Copy link
Contributor Author

I just tried unpatched 20.08 and the same RYD text issues are present there. It's an issue with YouTube itself.

@MarcaDian

This comment has been minimized.

Sign in to view
@cyberboh
Copy link

I just tried unpatched 20.08 and the same RYD text issues are present there. It's an issue with YouTube itself.

I was thinking it was not a bug.
Starting 20.07 onwards, Google changed the likes dislikes font.

@MarcaDian

This comment has been minimized.

Sign in to view
@cyberboh
Copy link

cyberboh commented Feb 21, 2025 •
edited
Loading

This happens during a double-tap to seek, if correctly guess the moment when the double tap animation ends and tap at this moment again, the bottom layout will not appear.
If double tap again, the layout will return.

Can someone confirm this bug? I tried to reproduce it on 19.50.41 RVP v5.12.0, or this is a bug of some hook (probably a double-tap to seek or fullscreen button), or a bug of the YouTube app itself, or a bug after #4469 , or a bug of this PR. Bug is present on 20.06.42 and 20.07.37 from my side.

I get the same on 20.06.42
19.50.41 is fine here with 5.12.0 patches.
So i guess this caused from this PR. Dunno how to debug

@LisoUseInAIKyrios
Copy link
Contributor Author

Nothing in this PR changes the final patched app (except for adding Miniplayer type 4, but that's unrelated). It must be something with 20.x.

@cyberboh
Copy link

Nothing in this PR changes the final patched app (except for adding Miniplayer type 4, but that's unrelated). It must be something with 20.x.

Oh... I remember the bug appears after i select miniplayer type 4. After i changed to type 3, it is fine.
So maybe patch for miniplayer type 4 is the culprit.

@LisoUseInAIKyrios
Copy link
Contributor Author

Additional miniplayer feature flags may need to be forced on/off when using type 4.

Or maybe it's just an issue with type 4 itself since it's still a work in progress by YT.

@cyberboh
Copy link

Or maybe it's just an issue with type 4 itself since it's still a work in progress by YT.

I think we don't know when it is ready

Additional miniplayer feature flags may need to be forced on/off when using type 4.

This is better solution for now.

@MarcaDian

This comment has been minimized.

Sign in to view
@LisoUseInAIKyrios
Copy link
Contributor Author

If it is caused by the fade out fix then it's odd the fullscreen button is also affected (or is it? I can't reproduce the issue and the screenshots above show fullscreen button is gone).

@MarcaDian

This comment has been minimized.

Sign in to view
@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Feb 21, 2025 •
edited
Loading

I reproduced the overlay buttons permanently hiding. Did not use double tap to skip, and happened on a player fullscreen Short. 19.47.53 on dev branch (not this PR).

Probably is something with the button fade out fix.

@MarcaDian can the fade out fix also be accomplished by requiring a restart and using invisible visibility, but use the prior patch animation logic? If that works then that's an easy fix and requiring a restart for the bottom buttons is worth it.

@MarcaDian
Copy link
Contributor

MarcaDian commented Feb 21, 2025 •
edited
Loading

View.INVISIBLE is required for proper transition.Fade animation. Otherwise, the button disappears before the animation ends, and the flickering effect appears as before.
Or the problem is that View.VISIBLE is not installed somewhere. I will try to add more checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX left review comments

@kitadai31 kitadai31 kitadai31 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LisoUseInAIKyrios @cyberboh @MarcaDian @oSumAtrIX @0xrxL @kitadai31