Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(analyze): only run when necessary #766

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

validcube
Copy link
Member

@validcube validcube commented Mar 29, 2023

🤖 - Run when necessary

Prevent unnecessary runs

The workflow will run on changes to lib/.dart and changes to the analyser itself.

resolve: #765

@validcube validcube marked this pull request as draft March 29, 2023 10:29
@validcube validcube marked this pull request as ready for review March 29, 2023 10:32
@validcube validcube changed the title ci(analyser): only run on lib/.dart changes ci(analyserrun when nesccesary Mar 29, 2023
@validcube validcube changed the title ci(analyserrun when nesccesary ci(analyser): run when necessary Mar 29, 2023
@PalmDevs PalmDevs changed the title ci(analyser): run when necessary ci(analyze): only run when necessary Mar 29, 2023
@PalmDevs PalmDevs requested a review from Ushie March 29, 2023 17:41
@Ushie Ushie merged commit 7839252 into ReVanced:dev Mar 29, 2023
Aunali321 added a commit that referenced this pull request Apr 20, 2023
* feat: remove notice about stale development [skip ci]

* feat(ci): update crowdin workflow to use new main branch

* ci: use `semantic-release` (#746)

* ci(release): fix wrong artifact name and ci not uploading build

* ci: use caching to speed up workflows (#760)

Use caching to speed up workflows: 9-14 minutes (ish) to 6-8 minutes (ish)

Commits:
* ci(release): use GitHub cache

* ci(release): restore signing

* ci(release): remove unnecessary variables in flutter build step

* ci(release): fix step not moving artifact to accessible path

* ci(release): use appropriate npm commands for ci environment

* ci(release): fix argument parsing of npm exec

* ci: dart analyser (#761)

* ci: dart analyser

* ci(analyser): clarify the dart analysing step

* refactor: ignore generated files

* ci(analyser): apply suggestion from code-reviewer

Co-Authored-By: Palm <palmpasuthorn@gmail.com>

* ci(analyser): apply suggestion from code-reviewer

Co-Authored-By: Palm <palmpasuthorn@gmail.com>

* ci(analyser): apply suggestion from code-reviewer

Co-authored-by: Palm <palmpasuthorn@gmail.com>

---------

Co-authored-by: Palm <palmpasuthorn@gmail.com>

* ci(analyze): only run when necessary (#766)

* ci(analyser): only run on lib/`.dart` changes

* ci(analyser): runs on workflow changes

* ci(analyze): run on all dart file changes

---------

Co-authored-by: Palm <palmpasuthorn@gmail.com>

* ci(release): update node dependencies

* chore(CHANGELOG): reset changelog

* feat: confirmation dialog for deleting keystore (#764)

* feat: confirmation dialog for deleting keystore

* refactor(i18n): apply suggestion from code-reviewer

Co-authored-by: Ushie <github@ushie.dev>

* refactor: apply suggestion from code-reviewer

Co-authored-by: Mipirakas <borismichiels@gmail.com>

---------

Co-authored-by: Ushie <github@ushie.dev>
Co-authored-by: Mipirakas <borismichiels@gmail.com>

* ci(release): update semantic-release

* feat: improve ux (#752)

* feat: restart app toast when changing sources, api url

* fix: potentially fix manager stuck on black screen

* feat: remove select all patches chip

* feat: show all apps and recommended versions

* chore(i18n): remove unused strings

remove unused strings left out in 7e05bca

* feat: select install type before patching

* feat: update patches button (#782)

* feat: update patches button

* feat: show toast when force refresh

* chore: don't translate "ReVanced Manager" and "ReVanced Patches"

* Revert "feat: select install type before patching"

This reverts commit 74e0c09.

* feat: rename recommended patches to default patches

* feat: add missing localization

* feat: display restart app toast for resetting source

---------

Co-authored-by: EvadeMaster <93124920+EvadeMaster@users.noreply.github.com>

* feat: add option to import/export keystore (#776)

* feat: add option to import/export keystore

* change the order of import/export keystore buttons

* feat: add option to change the keystore password

* feat: trim extra space when setting custom source (#771)

* chore: update dependencies (#772)

* chore: updated some dependencies

* refactor: reimplemented cache interceptor

* Revert "Updated dependencies & migrated breaking changes"

This reverts commit e6743b0.

* chore: migrated flutter_local_notifications

* revert: reimplemented cache interceptor

* fix: open contributor links externally (#791)

* feat: auto select default patches

* style: sort imports

* feat: progress bar for manager updates

* feat: appreciation message for new contributors

* docs: remove alpha disclaimer

* feat: disable selecting installed apps for nonroot

* feat: warning for armv7 devices

* chore: add missing translations

* feat: resetting source to default dismiss the sources pop-up (#797)

* feat: resetting source to default dismiss the sources pop-up

* chore: format using `dart format`

---------

Co-authored-by: Ushie <github@ushie.dev>
Co-authored-by: Palm <palmpasuthorn@gmail.com>
Co-authored-by: EvadeMaster <93124920+EvadeMaster@users.noreply.github.com>
Co-authored-by: Mipirakas <borismichiels@gmail.com>
Co-authored-by: Sebok Andras <sebokandris2009@gmail.com>
Co-authored-by: Aman Sikarwar <amansik.1910@gmail.com>
Co-authored-by: Yaros <thedj.launchpadder.dmx512@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(analyse-code): run only when necessary
3 participants