Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(patch-item): remove redundant patch version completely #1059

Merged
merged 2 commits into from
Jul 29, 2023
+1 −14
Merged

fix(patch-item): remove redundant patch version completely #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ad7468
fix(patch-item): remove redundant patch version
TheAabedKhan Jul 28, 2023
ee5545c
fix: remove patch version completely
TheAabedKhan Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/models/patch.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class Patch {
Patch({
required this.name,
required this.description,
required this.version,
required this.excluded,
required this.dependencies,
required this.compatiblePackages,
Expand All @@ -17,7 +16,6 @@ class Patch {
factory Patch.fromJson(Map<String, dynamic> json) => _$PatchFromJson(json);
final String name;
final String description;
final String version;
final bool excluded;
final List<String> dependencies;
final List<Package> compatiblePackages;
Expand Down
1 change: 0 additions & 1 deletion lib/ui/views/patches_selector/patches_selector_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ class _PatchesSelectorViewState extends State<PatchesSelectorView> {
(patch) => PatchItem(
name: patch.name,
simpleName: patch.getSimpleName(),
version: patch.version,
description: patch.description,
packageVersion: model.getAppVersion(),
supportedPackageVersions:
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/widgets/patcherView/patch_selector_card.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class PatchSelectorCard extends StatelessWidget {
String _getPatchesSelection() {
String text = '';
for (final Patch p in locator<PatcherViewModel>().selectedPatches) {
text += '\u2022 ${p.getSimpleName()} (v${p.version})\n';
text += '\u2022 ${p.getSimpleName()}\n';
}
return text.substring(0, text.length - 1);
}
Expand Down
10 changes: 0 additions & 10 deletions lib/ui/widgets/patchesSelectorView/patch_item.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class PatchItem extends StatefulWidget {
required this.name,
required this.simpleName,
required this.description,
required this.version,
required this.packageVersion,
required this.supportedPackageVersions,
required this.isUnsupported,
Expand All @@ -25,7 +24,6 @@ class PatchItem extends StatefulWidget {
final String name;
final String simpleName;
final String description;
final String version;
final String packageVersion;
final List<String> supportedPackageVersions;
final bool isUnsupported;
Expand Down Expand Up @@ -90,14 +88,6 @@ class _PatchItemState extends State<PatchItem> {
),
],
),
const SizedBox(height: 1),
Text(
widget.version,
style: TextStyle(
fontSize: 14,
color: Theme.of(context).colorScheme.secondary,
),
),
const SizedBox(height: 4),
Text(
widget.description,
Expand Down