Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show what version of ReVanced Patches was used to patch an app within 'app info' for a patched app. #995

Open
4 tasks done
11BelowStudio opened this issue Jul 5, 2023 · 4 comments
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@11BelowStudio
Copy link

Type

Functionality

Issue

  • Selecting 'applied patches' in 'App info' for a patched app, shows the names of the patches installed, but there's no way for a user to double-check the source of the patches/version of the patch source
  • Also seeing as individual patch version numbers are apparently going to be removed, being able to check the version of ReVanced Patches (or alternative) used is the next best thing.

Feature

  • When patching an app, save the source of the patches + version number of the patch source somewhere
  • Display this info in 'app info' via the manager
  • OPTIONAL - inform a user if a newer version of the patch source exists

Motivation

  • Permits users to double-check what source they used to patch their app, and what version of that source they patched it with
  • Allowing users to see this allows users whom need to report a bug with a particular patch to verify that they aren't using an outdated version of the patch
  • Also could permit a reminder for a user to re-patch their app if they install a new Patches version

Additional context

Pretty much the same overall request as #994 - but using the closest available thing to individual patch version numbers seeing as those are apparently going to get removed.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@11BelowStudio 11BelowStudio added the Feature request Requesting a new feature that's not implemented yet label Jul 5, 2023
@TheAabedKhan
Copy link
Member

TheAabedKhan commented Aug 5, 2023

@ILoveOpenSourceApplications The ReVanced Patches version is removed completely from the API and from the manager as well. I didn't know this issue exists. This can be closed.

@TheAabedKhan TheAabedKhan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2023
@ILoveOpenSourceApplications

I think you misunderstood the issue. What the user meant isn't the individual patches version, but the patch release version which currently is 2.187.0 to be shown under app info.

@TheAabedKhan TheAabedKhan reopened this Aug 5, 2023
@TheAabedKhan
Copy link
Member

I think you misunderstood the issue.

Oh, yes! ReVanced Patches version. OK. Will add this.

@KobeW50
Copy link
Contributor

KobeW50 commented Nov 22, 2023

On a slightly related note, the patch options used should also be added to the App Info in the Patched apps section

(Although this probably shouldn't be added into flutter manager at this point. Feel free to mark as off-topic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

4 participants