Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show applied patch version numbers in the 'Applied patches' dialog #994

Closed
4 tasks done
11BelowStudio opened this issue Jul 5, 2023 · 4 comments
Closed
4 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@11BelowStudio
Copy link

Type

Functionality

Issue

  • Selecting 'applied patches' in 'App info' for a patched app, shows the names of the patches installed, but doesn't say what version is installed.
    • Like so:
    • see https://github.com/revanced/revanced-manager/assets/60523642/a6ab86cd-d33a-4706-8338-e7c1bf3b831f (it's a list of patch names but there's no version numbers)
  • This makes it pretty hard to find out what version of a patch one currently has installed, in case there's a problem with the currently-installed patch version or in case one wants to check if an updated version of that patch exists.

Feature

  • Add the version number of the installed patch after the names of each patch in the 'applied patches' dialog
    • So, instead of saying * Copy Video URL, it would say * Copy Video URL (0.0.1) assuming one currently has version 0.0.1 of that patch patched in.

Motivation

  • Ensures that a user can manually check if an update to patch they are using has been released, in lieu of an automated means of telling a user that an updated version of their patches are available.
  • Allowing a user to see what patch version they have installed allows users whom need to report a bug with a particular patch to verify that they aren't using an outdated version of the patch

Additional context

  • If there already is something buried in the ReVanced Manager stating the installed versions of the patches one is using, it's rather poorly-signposted.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@11BelowStudio 11BelowStudio added the Feature request Requesting a new feature that's not implemented yet label Jul 5, 2023
@oSumAtrIX
Copy link
Member

Patch versioning will be removed soon because it wasn't used

@11BelowStudio
Copy link
Author

So is there any means for an end-user to find out if the patches they currently have applied have updates available or not?

@oSumAtrIX
Copy link
Member

Yes, the version of ReVanced Patches, not the individual ones

@11BelowStudio
Copy link
Author

welp, just made an amended feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

2 participants