Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: update progress bar glitching out #936

Closed
4 tasks done
ILoveOpenSourceApplications opened this issue Jun 12, 2023 · 1 comment · Fixed by #937
Closed
4 tasks done

bug: update progress bar glitching out #936

ILoveOpenSourceApplications opened this issue Jun 12, 2023 · 1 comment · Fixed by #937
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications

Type

Error while running the manager

Bug description

When an update for manager is out and if the user hits update, the download progress bar shows up. If the user accidentally taps anywhere on the screen, the pop up glitches out and the user if left with a tall grey pop up which says downloading at the top.

Steps to reproduce

  1. Make sure an update is available.
  2. Tap the update button.
  3. Tap somewhere on the screen after the update progresses.
  4. Glitched out pop up shows up when pressing update again.

Android version

Android 13

Manager version

1.3.5

Target package name

ReVanced Manager

Target package version.

Nil

Installation type

Non-root

Patches selected.

Nil

Device logs (exported using Manager settings).

Nil

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

screen-20230612-132158.mp4

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager and not related to patching errors or patches
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Jun 12, 2023
TheAabedKhan added a commit to TheAabedKhan/revanced-manager that referenced this issue Jun 12, 2023
When a user clicks on cancel while downloading the update, managerUpdateProgress is closed. This results in completely canceling the Stream and that's why the user cannot download the update without re-launching the app.

Closes ReVanced#936
@TheAabedKhan
Copy link
Member

Fixed by #937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants