bug: Update option

[ILoveOpenSourceApplications]

Type

Error at runtime

Bug description

When we're opening the manager, the manager shows the update option which is clickable for a split second. Upon clicking you get the update pop-up and you're able to install the same version over and over again.

Steps to reproduce

Step 1: Make sure to close the manager.
Step 2: Open the manager and be quick enough to click the update option.
Step 3: You can go into a cycle of installing the same version if you're into it.

Android version

Android 13

Manager version

1.2.0

Target package name

ReVanced Manager

Target package version.

1.0.0 and above I believe

Installation type

Non-root

Patches selected.

Nil

Device logs (exported using Manager settings).

Nil

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

Video:

screen-20230524-130013.2.mp4

Screenshot:

Solution

No response

Additional context

No response

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.
• The issue is related solely to the ReVanced Manager and not related to patching errors or patches

[sFeri01]

Yes, the apk on the github release page also installs 1.2.0

[SpL1Ne]

1.3.0 Still there. After clicking update button it becomes disabled.

Screenshots

[YarosMallorca]

This issue seems to be fixed on the main branch.

Video:
https://drive.google.com/file/d/1xsXpb9f72ktn57sDPDJ2kN4hieqp6y9Y/view?usp=drivesdk

Edit:
It is still reproducible on slow internet connections. I'll look into it.

[ILoveOpenSourceApplications]

Edit: It is still reproducible on slow internet connections. I'll look into it.

Didn't have to do us like that. But glad that you were able to reproduce the issue.

[validcube]

🎉 This issue might have been fixed in #932, please wait for the next release of ReVanced Manager!