Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve suggested app version text #818

Closed
4 tasks done
Ushie opened this issue Apr 27, 2023 · 2 comments
Closed
4 tasks done

feat: improve suggested app version text #818

Ushie opened this issue Apr 27, 2023 · 2 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Ushie
Copy link
Member

Ushie commented Apr 27, 2023

Type

Cosmetic

Issue

Right now, ReVanced Manager shows a recommended version when selecting an application, the wording may be a bit confusing to the user as it's only a recommendation

Feature

Switch recommended for supported, this will clarify that things are likely NOT going to work if you don't follow the supported version

Motivation

Clarification for which version of the app should be patched and reduce the number of people confused due to their patched application not working

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@Ushie Ushie added the Feature request Requesting a new feature that's not implemented yet label Apr 27, 2023
SodaWithoutSparkles added a commit to SodaWithoutSparkles/revanced-manager that referenced this issue Apr 28, 2023
SodaWithoutSparkles added a commit to SodaWithoutSparkles/revanced-manager that referenced this issue Apr 28, 2023
SodaWithoutSparkles added a commit to SodaWithoutSparkles/revanced-manager that referenced this issue Apr 28, 2023
@Ushie Ushie closed this as completed Apr 28, 2023
@KobeW50
Copy link
Contributor

KobeW50 commented May 18, 2023

I'm just confused as to why in 1.1.0 it says "Suggested" instead of "Supported" even after this was marked completed.

Suggested is a soft word.

@Ushie
Copy link
Member Author

Ushie commented May 18, 2023

I'm just confused as to why in 1.1.0 it says "Suggested" instead of "Supported" even after this was marked completed.

Suggested is a soft word.

You can read the associated issue (#822) where discussion happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

2 participants