Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: not all Installed apps show up if source is different #692

Closed
4 tasks done
ILoveOpenSourceApplications opened this issue Feb 10, 2023 · 8 comments
Closed
4 tasks done
Assignees
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications
Copy link

ILoveOpenSourceApplications commented Feb 10, 2023

Type

Error while running the manager

Bug description

Even after the latest fix #1022, YouTube and YTM apps installed from custom sources (inotia00) don't show up under installed apps. Initially this was working fine, but after #674 this feature broke and is still broken till day. Shouldn't the manager know which app is installed by it even if it's a custom source.

Steps to reproduce

  1. Update to manager version to 1.4.1
  2. Still there is no YT or YTM being shown under installed apps.

Android version

Android 13

Manager version

1.4.1

Target package name

ReVanced Manager

Target package version.

Nil

Installation type

Non-root

Patches selected.

Nil

Device logs (exported using Manager settings).

Nil

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

Nil

Screenshots or videos

Screenshot_20230716-010304~2

Solution

Identify the latest version and date of installation.

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager and not related to patching errors or patches
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Feb 10, 2023
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title Bug regarding potentially fix apps disappearing when update is available Bug regarding "potentially fix apps disappearing when update is available" Feb 10, 2023
@ILoveOpenSourceApplications
Copy link
Author

Okay I seem to have found why in my device (Pixel) in particular was showing "no patched applications installed". I was having a custom source (inotia00). Today, due to a bug occuring in RVX I installed ReVanced and lo and behold, there's a YouTube app under patched applications. The date and app version is accurate to what ReVanced is offering currently but when I swapped back to custom source again and installed RVX, the installed time looks okay but the app version is still what ReVanced is offering and the applied patches list is showing RVX patches in it. And when I uninstalled ReVanced YouTube, it once again became "no patched applications installed".

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title Bug regarding "potentially fix apps disappearing when update is available" Bug: The "potentially fix apps disappearing when update is available" is affected by source Mar 2, 2023
@ILoveOpenSourceApplications
Copy link
Author

This issue is related to the manager right? Cause for rooted users I've seen that even though they have custom sources they're still having the patched apps show up under installed section.

@ILoveOpenSourceApplications
Copy link
Author

If one is not quick enough it'll disappear after a few seconds:

screen-20230425-155130.3.mp4

If one is quick enough they can go into info but when backing out it'll disappear:

screen-20230425-155839.2.mp4

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title Bug: The "potentially fix apps disappearing when update is available" is affected by source Bug: The potentially fix apps disappearing when update is available is what it says May 2, 2023
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title Bug: The potentially fix apps disappearing when update is available is what it says Bug: potentially fix apps disappearing when update is available May 2, 2023
@TheAabedKhan
Copy link
Member

@ILoveOpenSourceApplications, maybe we should wait until the next release to confirm this issue still exists and needs to be fixed. If it exists even after the release, then update the steps to reproduce in the description.

@ILoveOpenSourceApplications
Copy link
Author

If one is not quick enough it'll disappear after a few seconds.

If one is quick enough they can go into info but when backing out it'll disappear.

This isn't happening anymore after #1022 either. Now there is no sign within the manager that such applications got installed.

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title Bug: potentially fix apps disappearing when update is available Bug: Installed apps doesn't show if source is different Jul 15, 2023
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title Bug: Installed apps doesn't show if source is different bug: Installed apps doesn't show if source is different Jul 15, 2023
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug: Installed apps doesn't show if source is different bug: not all Installed apps doesn't show if source is different Jul 15, 2023
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug: not all Installed apps doesn't show if source is different bug: not all Installed apps show up if source is different Jul 15, 2023
@Ushie
Copy link
Member

Ushie commented Aug 5, 2023

Is this considered resolved in that case?

@ILoveOpenSourceApplications
Copy link
Author

No actually. Previously there was a second where the manager would show the installed app which can be seen in this comment. But now that's not even the case as it's completely blank irrespective of how many times the user installs the app.

@ILoveOpenSourceApplications
Copy link
Author

I believe #1311 resolved this issue and can be closed. Thanks for the fix @oSumAtrIX .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants