Skip to content

Commit

Permalink
fix(patch-item): remove redundant patch version completely (#1059)
Browse files Browse the repository at this point in the history
  • Loading branch information
TheAabedKhan authored Jul 29, 2023
1 parent c27ca08 commit 096b315
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 14 deletions.
2 changes: 0 additions & 2 deletions lib/models/patch.dart
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class Patch {
Patch({
required this.name,
required this.description,
required this.version,
required this.excluded,
required this.dependencies,
required this.compatiblePackages,
Expand All @@ -17,7 +16,6 @@ class Patch {
factory Patch.fromJson(Map<String, dynamic> json) => _$PatchFromJson(json);
final String name;
final String description;
final String version;
final bool excluded;
final List<String> dependencies;
final List<Package> compatiblePackages;
Expand Down
1 change: 0 additions & 1 deletion lib/ui/views/patches_selector/patches_selector_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ class _PatchesSelectorViewState extends State<PatchesSelectorView> {
(patch) => PatchItem(
name: patch.name,
simpleName: patch.getSimpleName(),
version: patch.version,
description: patch.description,
packageVersion: model.getAppVersion(),
supportedPackageVersions:
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/widgets/patcherView/patch_selector_card.dart
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class PatchSelectorCard extends StatelessWidget {
String _getPatchesSelection() {
String text = '';
for (final Patch p in locator<PatcherViewModel>().selectedPatches) {
text += '\u2022 ${p.getSimpleName()} (v${p.version})\n';
text += '\u2022 ${p.getSimpleName()}\n';
}
return text.substring(0, text.length - 1);
}
Expand Down
10 changes: 0 additions & 10 deletions lib/ui/widgets/patchesSelectorView/patch_item.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class PatchItem extends StatefulWidget {
required this.name,
required this.simpleName,
required this.description,
required this.version,
required this.packageVersion,
required this.supportedPackageVersions,
required this.isUnsupported,
Expand All @@ -25,7 +24,6 @@ class PatchItem extends StatefulWidget {
final String name;
final String simpleName;
final String description;
final String version;
final String packageVersion;
final List<String> supportedPackageVersions;
final bool isUnsupported;
Expand Down Expand Up @@ -90,14 +88,6 @@ class _PatchItemState extends State<PatchItem> {
),
],
),
const SizedBox(height: 1),
Text(
widget.version,
style: TextStyle(
fontSize: 14,
color: Theme.of(context).colorScheme.secondary,
),
),
const SizedBox(height: 4),
Text(
widget.description,
Expand Down

0 comments on commit 096b315

Please sign in to comment.