Renamed Argument Labels

[TaeJoongYoon]

I edit functions in Router name and arguments according to API Design Guidelines

// From
routingActionsForTransitionFrom(_ oldRoute:,newRoute:)
// To
routingActionsForTransition(from oldRoute:,to newRoute:)

// From
routableIndexForRouteSegment(_ segment:)
// To
routableIndex(for segment:)

[mjarvis]

@TaeJoongYoon Thanks for contributing!

When we rename or remove any public facing interfaces, we need to provide deprecated forwards from the old functions to avoid breaking backwards compatibility.

[Edit]: Looks like we have breaking changes planned for v0.7.0 anyways so no need to add deprecation markers. Sorry!

[DivineDominion]

@TaeJoongYoon Travis reports Use of unresolved identifier 'routableIndexForRouteSegment' -- have you overlooked an occurence during the renaming process?

[TaeJoongYoon]

@mjarvis
It's okay! :) If needed, I will add it.

@DivineDominion
I'm sorry. I missed it one line. I edited it and commit it!

[DivineDominion]

@TaeJoongYoon There seems to be more typos :)
https://travis-ci.org/ReSwift/ReSwift-Router/jobs/535598154#L2080

The for: is missing. (I suggest you ⌘U run tests locally too to catch this)

[mjarvis]

It would also be beneficial to add an entry to Changelog.md referencing these breaking changes

[TaeJoongYoon]

@DivineDominion I'm sorry.. test succeed.

@mjarvis Do I add it?

[DivineDominion]

@TaeJoongYoon Great!

Regarding the CHANGELOG: yes, please! For example:

- Renamed argument labels for modern Swift conformance (#116) - @TaeJoongYoon

Or whatever you find fitting.

[TaeJoongYoon]

@DivineDominion I added it with comments!

[codecov-io]

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #116   +/-   ##
======================================
  Coverage    85.5%   85.5%           
======================================
  Files           5       5           
  Lines         200     200           
======================================
  Hits          171     171           
  Misses         29      29

Impacted Files	Coverage Δ
ReSwiftRouter/Router.swift	84.66% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e9173...7662501. Read the comment docs.

[mjarvis]

Suggested change

	- Renamed argument labels for modern Swift conformance ([#116](<https://github.com/ReSwift/ReSwift-Router/pull/115>)) - @TaeJoongYoon
	- Renamed argument labels for modern Swift conformance ([#116](<https://github.com/ReSwift/ReSwift-Router/pull/116>)) - @TaeJoongYoon

(fixed the pull request number in the URL)

[TaeJoongYoon]

My apology for the typo...

[TaeJoongYoon]

Do I have to do anything extra?

[DivineDominion]

I don't see anything else. I'll merge it once this is fixed 👍

[TaeJoongYoon]

Okay. I fixed it :)

[peril-reswift]

@TaeJoongYoon Thanks a lot for contributing to ReSwift! We've invited you to join
the ReSwift GitHub organization – no pressure to accept! If you'd like more
information on what that means, check out our contributor guidelines.

Generated by 🚫 dangerJS