Fixing build system to use setuptools and wheel install #376
Conversation
E3V3A
commented
Nov 29, 2018
- fixes issue Fixing build system #336
- Added build artifact src/binwalk.egg-info to .gitignore
- Updated INSTALL.md to use pip install .
- Added setup.cfg for pip
- Changed setup.py to comply to pip setuptools install
- Copied binwalk.py to src/binwalk/main.py
* fixes issue ReFirmLabs#336 * Added build artifact src/binwalk.egg-info to .gitignore * Updated INSTALL.md to use pip install . * Added setup.cfg for pip * Changed setup.py to comply to pip setuptools install * Copied binwalk.py to src/binwalk/__main__.py
setup.cfg
Outdated
| setuptools | ||
|
|
||
| #test_suite = tests.tests.Tests | ||
| dependency_links = ['git+https://github.com/devttys0/yaffshiv.git'] |
There was a problem hiding this comment.
remove. When I have written the patch, dependency_links were supported, now they are dropped in favour of PEP 508.
| [options.extras_require] | ||
| plots = matplotlib | ||
| x86 = capstone | ||
| YAFFS = yaffshiv |
There was a problem hiding this comment.
should be yaffshiv @ git+https://github.com/devttys0/yaffshiv.git but currently it doesn't work because of the bug in pip which is not fixed even in master.
Moved. |
|
IDK what's the problem with Travis... :( |
setup.cfg
Outdated
|
|
||
| [options.extras_require] | ||
| plots = matplotlib | ||
| x86 = capstone | ||
| YAFFS = yaffshiv | ||
| #SQUASH = sasquatch | ||
| #YAFFS = yaffshiv @ git+https://github.com/devttys0/yaffshiv.git |
There was a problem hiding this comment.
This breaks things. You need to comment out the part starting from @, not to comment out the line entirely.
setup.cfg
Outdated
| YAFFS = yaffshiv | ||
| #SQUASH = sasquatch | ||
| #YAFFS = yaffshiv @ git+https://github.com/devttys0/yaffshiv.git | ||
| #SQUASH = sasquatch @ git+https://github.com/devttys0/sasquatch.git' |
There was a problem hiding this comment.
you have forgotten the tick
There was a problem hiding this comment.
Should I just remove them altogether then?
There was a problem hiding this comment.
I guess, no. YAFFS should be kept - 3rd party packages may depend on it, if you removed this optional dependency, they would be broken.
I prefer to keep these commented out lines as a reminder to fix them in future when the bug in pip will be fixed.
Travis has lots of problems, they use obsolete ubuntu trusty, all my packages have failed to be built there, we should use other CI like GitLab or Appveyor. |
|
Don't forget to squash all the commits into a single one, rewriting the history. |
isn't that done automagically? (I can't find the button for that.) |
|
@E3V3A, It's done on your computer, not on GitHub. |
|
@KOLANICH |
|
Anyway, I can't do this all day/night. So since it seem that other people know what exactly to do, so please do it. I was just hoping to help out and make things move. So please merge and fix or whatever is necessary. Surely the setup.py need a lot more maintenance. It's almost unreadable as it is right now, and I think the distutils import may need to be replaced, but I could be wrong. I'm quite new to packing... |
setup.py
Outdated
| @@ -7,11 +11,18 @@ | |||
| from distutils.core import setup, Command | |||
There was a problem hiding this comment.
ouch. setup, should be removedk we use setuptools setup
|
This PR is so embarrassingly ugly I'm closing it to send a new one! |