Fixes for test.data.table() in foreign mode
#6808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6808 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 79 79
Lines 14639 14642 +3
=======================================
+ Hits 14440 14444 +4
+ Misses 199 198 -1 ☔ View full report in Codecov by Sentry. |
|
Generated via commit 81b09fb Download link for the artifact containing the test results: ↓ atime-results.zip
|
This is already done for warnings and errors. Unfortunately, some tests do check output and conditions by hand, so test.data.table() still requires LANGUAGE=en for now.
A comment near 1832.2 said that output= was inapplicable due to square bracket matching. The actual source of the problem was the caret only matching start of string instead of start of line.
While not all all.equal() output is translated, those cases that are result in test failures when comparing the output in test() calls. Use output= so that the test would be skipped in 'foreign' mode.
We already only count warnings in foreign mode, don't match their text contents. With ignore.warning set, we lack a way to figure out when the translated warning should be skipped, so don't count them at all.
The length(output) || length(notOutput) branch makes length(output) at least 1. Later, 'y' value check is skipped if length(output) is nonzero. Instead of skipping this branch altogether in foreign mode, make sure that it's taken so that the 'y' value check is later skipped when foreign mode is on.
Instead of applying passed options= for the rest of the call frame, undo them immediately after evaluating the call. This prevents testing for options(datatable.alloccol=...) from breaking the internal data.table usage and allows rewriting the tests using the options=... and error=... arguments, which skip tests as appropriate in foreign mode.
f48097b to
2068510
Compare
|
The important part now exists as #6811. May need more changes if more of |
| test(432.3, inherits(err3,"try-error") && grep("is a numeric vector ok but its length is 2. Its length should be 1.", err3)) | ||
| test(432.4, inherits(err4,"try-error") && grep("It must be >=0 and not NA.", err4)) | ||
| test(432.5, inherits(err5,"try-error") && grep("It must be >=0 and not NA.", err5)) | ||
| # Test that unsetting datatable.alloccol is caught, #2014 |
There was a problem hiding this comment.
great fix & modernization!
MichaelChirico
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks! For posterity please also tidy up the PR description which still discusses the catf() part that was split off to #6811.
test.data.table()test.data.table() in foreign mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve the the quality of life when running
test.data.table()without an English locale set or translation disabled. Tests that previously usedcapture.outputnow useoutput=..., which is skipped in foreign mode. Tests are also skipped in foreign mode forignore.warningsandnotOutput.