Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Brazilian .po files #6776

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Updated Brazilian .po files #6776

wants to merge 13 commits into from

Conversation

MichaelChirico
Copy link
Member

Thanks in advance!

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Jan 30, 2025
@MichaelChirico MichaelChirico requested a review from a team as a code owner January 30, 2025 07:47
@MichaelChirico MichaelChirico requested a review from a team as a code owner January 30, 2025 07:55
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (d0887df) to head (bc942b4).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6776      +/-   ##
==========================================
+ Coverage   98.60%   98.64%   +0.04%     
==========================================
  Files          79       79              
  Lines       14641    14642       +1     
==========================================
+ Hits        14437    14444       +7     
+ Misses        204      198       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rffontenelle rffontenelle removed the request for review from a team February 2, 2025 20:08
@rffontenelle
Copy link
Contributor

Hi @MichaelChirico! Can you please remind me how can I update the source strings of a PO file and get the number of chars per line wrapped as is in the data.table repository? The translation editor software re-wrapped so the git diff looks polluted.

@MichaelChirico
Copy link
Member Author

I update the .po files with potools::po_update(), does that help?

@rffontenelle
Copy link
Contributor

Sadly no. I don't exactly how po_update works, but it didn't update R-/pt_BR.po files. I even replaced POT-Creation-Date to some previous date, but it didn't touch them.

@MichaelChirico
Copy link
Member Author

Thanks. Feel free to just leave the .po update in the format your editor has in this PR, and I'll be sure to get it into the nicer format to reduce the diff before squash+merge.

@rffontenelle
Copy link
Contributor

Done, PO file updated. Translation by @leofontenelle, proofread by me.

Chirico, I'd love to know how to adjust the line wrap, if you can check it later and share will me. Thanks in advance!

@MichaelChirico
Copy link
Member Author

Hi @rffontenelle, I ran po_update() again to incorporate the recent changes to .pot (#6793 -- 3e900c9). For some reason your translations weren't copied over well so I tried to manually restore them.

I also made one correction: there are two messages for "too-many" vs. "too-few", I saw "muito poucos" for both in Portuguese, looked wrong. I think the correction is just "muitos" for the "too-many" case.

For the wrapping, AFAICT it's properly wrapped (I looked at the profile of nchar() and it looks similar to the other languages).

PTAL.

@rffontenelle
Copy link
Contributor

I also made one correction: there are two messages for "too-many" vs. "too-few", I saw "muito poucos" for both in Portuguese, looked wrong. I think the correction is just "muitos" for the "too-many" case.

Indeed that's not correct.

I'll take a look a them.

Just for the record:

$ LC_ALL=C msgfmt pt_BR.po 
pt_BR.po:3365: number of format specifications in 'msgid' and 'msgstr' does not match
pt_BR.po:3412: number of format specifications in 'msgid' and 'msgstr' does not match
msgfmt: found 2 fatal errors
647 translated messages, 6 fuzzy translations, 14 untranslated messages.
$ LC_ALL=C msgfmt R-pt_BR.po 
468 translated messages, 1 fuzzy translation, 100 untranslated messages.

@MichaelChirico MichaelChirico added this to the 1.17.0 milestone Feb 7, 2025
@rffontenelle
Copy link
Contributor

@leofontenelle pt_BR.po translated, feel free to review. Now I'm working on R-pt_BR.po

@rffontenelle
Copy link
Contributor

For the wrapping, AFAICT it's properly wrapped (I looked at the profile of nchar() and it looks similar to the other languages).

@MichaelChirico Looks like the line-wrapping problem is not the number of chars, but where to wrap. I'm using Gtranslator and it seems to not break as.name in different lines when line-wrapping: while Gtranslator put them together, potools leaves 'as.' in one line and name in the other.

The resulting string is the same, but the commit diff gets a bit polluted with these different line-wrapping rules.

For the last commit, I manually undid the wrapping-only changes done by my editor.

@rffontenelle
Copy link
Contributor

R-pt_BR translated. 2 strings fuzzy because I was not sure how to translate it. Pending review

@@ -194,6 +220,14 @@ msgstr ""
"usadas na junção. "

#: bmerge.R:71
msgid "Matching %s factor levels to %s factor levels."
msgstr "Correspondendo níveis de fator de %s a níveis de fator de %s."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que tal? "Fazendo os níveis do fator %s corresponderem aos níveis do fator %s."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Correspondendo níveis de fator de %s a níveis de fator de %s."
msgstr "Fazendo os níveis do fator %s corresponderem aos níveis do fator %s."


#: bmerge.R:80
msgid "Matching character column %s to factor levels in %s."
msgstr "Correspondendo coluna de caracteres %s para níveis de fator em %s."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que tal? "Fazendo a coluna de caracteres %s corresponder aos níveis do fator %s."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Correspondendo coluna de caracteres %s para níveis de fator em %s."
msgstr "Fazendo a coluna de caracteres %s corresponder aos níveis do fator %s."

#: bmerge.R:90
#: bmerge.R:91
msgid "%s has same type (%s) as %s. No coercion needed."
msgstr "%s tem o mesmo tipo (%s) como %s. Nenhuma coerção necessária."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que tal? "%s tem o mesmo tipo (%s) de %s. Nenhuma coerção necessária."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "%s tem o mesmo tipo (%s) como %s. Nenhuma coerção necessária."
msgstr "%s tem o mesmo tipo (%s) de %s. Nenhuma coerção necessária."


#: bmerge.R:170
msgid "on= matches existing index, using index"
msgstr "on= corresponde a índice existente, usando índice"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "on= corresponde a índice existente, usando índice"
msgstr "on= corresponde ao índice existente, usando índice"


#: bmerge.R:165
msgid "on= matches existing key, using key"
msgstr "on= corresponde a chave existente, usando chave"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está correto, mas entendi errado na primeira leitura. Que tal "... corresponde à chave existente ..."?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "on= corresponde a chave existente, usando chave"
msgstr "on= corresponde à chave existente, usando chave"

#: test.data.table.R:245
#: test.data.table.R:202
msgid "Running %d of %d tests matching '%s'"
msgstr "Executando %d de %d testss correspondendo a '%s'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testes

#: test.data.table.R:538
msgid "Test %s ran without errors but failed check that x equals y:"
msgstr ""
"O teste %s foi executado sem erros, mas falhou na verificação de que x é "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talvez?

... de x ser igual a y:

#: bmerge.R:214
msgid " Found %d non-equi group ...\n"
msgid_plural " Found %d non-equi groups ...\n"
msgstr[0] " Encontrado %d grupo não-equi ...\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grupo por desigualdade

msgid " Found %d non-equi group ...\n"
msgid_plural " Found %d non-equi groups ...\n"
msgstr[0] " Encontrado %d grupo não-equi ...\n"
msgstr[1] " Encontrado %d grupos não-equi ...\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grupos por desigualdade

"Duplicate column names found in molten data.table. Setting unique names "
"using 'make.names'"
msgstr ""
"Nomes de colunas duplicados encontrados em data.table fundida. Definindo "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... encontrados na data.table "derretida"

"'9'."
msgstr ""
"Ao contrário do esperado, como no ASCII, o caractere ':' não está logo antes "
"de '0'."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo depois de '9'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants