Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macro redefined in fwrite and fread #6384

Merged
merged 3 commits into from
Aug 20, 2024
Merged

macro redefined in fwrite and fread #6384

merged 3 commits into from
Aug 20, 2024

Conversation

ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Aug 20, 2024

Currently both freadR.h and fwrite.h have the line #define STRICT_R_HEADERS (see also at CI but happens at test-lin-dev-clang-cran and test-lin-dev-gcc-strict-cran)

This PR adds a directive to only define once, avoiding redefinition.

Copy link

Comparison Plot

Generated via commit cc9cca2

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 29 seconds

Time taken to run atime::atime_pkg on the tests: 5 minutes and 50 seconds

@MichaelChirico
Copy link
Member

Seems harmless, thanks!

@MichaelChirico MichaelChirico merged commit f8f9df4 into master Aug 20, 2024
7 of 8 checks passed
@MichaelChirico MichaelChirico deleted the strict_r_headers branch August 20, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants