adding an atime test case Performance Regression with .N and := #PR5463 #6169
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,6 +119,22 @@ test.list <- atime::atime_test_list( | |
| data.table:::setDT(L) | ||
| }, | ||
| Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) | ||
| Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"),# Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) | ||
|
|
||
| # Issue reported in: https://github.com/Rdatatable/data.table/issues/5424 | ||
| # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 | ||
| ".N and := regression fixed in #5463" = atime::atime_test( | ||
| N = 10^seq(1, 4), | ||
| setup = { | ||
| set.seed(123L) | ||
| dt <- data.table( | ||
| id = seq_len(N), | ||
| val = rnorm(N)) | ||
| dt | ||
| }, | ||
| expr = data.table:::`[.data.table`(dt, , .(vs = (sum(val))), by = .(id)), | ||
| Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854", # Parent of the regression causing commit (https://github.com/Rdatatable/data.table/commit/e793f53466d99f86e70fc2611b708ae8c601a451) in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) | ||
|
There was a problem hiding this comment. please use comment templates https://github.com/Rdatatable/data.table/wiki/Performance-testing#documentation-of-historical-commits otherwise use Parent of first commit (COMMIT_LINK) in the PR (PR_LINK) which causes the issue |
||
| Regression = "e793f53466d99f86e70fc2611b708ae8c601a451", # Commit responsible for regression in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) | ||
| Fixed = "58409197426ced4714af842650b0cc3b9e2cb842") # Last commit in the PR that fixed the regression (https://github.com/Rdatatable/data.table/pull/5463/commits) | ||
| ) | ||
| # nolint end: undesirable_operator_linter. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove line with
dtby itself which does nothing but is potentially confusingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright