Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain earlier dcast(fill=list(...)) behavior relying on base coercion behavior for lists #6051

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

MichaelChirico
Copy link
Member

This is #5980.

Not closing since label:revdep issues should be closed when revdep check officially removes it, but confirmed locally that {neonPlantEcology} now passes its tests.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (53df7e5) to head (1696771).
Report is 31 commits behind head on master.

❗ Current head 1696771 differs from pull request most recent head 658255b. Consider uploading reports for the commit 658255b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6051      +/-   ##
==========================================
- Coverage   97.51%   97.51%   -0.01%     
==========================================
  Files          80       80              
  Lines       14920    14919       -1     
==========================================
- Hits        14549    14548       -1     
  Misses        371      371              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico requested a review from tdhock April 9, 2024 14:30
@MichaelChirico MichaelChirico merged commit 26c558d into master Apr 10, 2024
3 checks passed
@MichaelChirico MichaelChirico deleted the coerce-list branch April 10, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants