Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Error Message for using := or let in Non-data.table-aware Environment #6019

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Enhance Error Message for using := or let in Non-data.table-aware Environment #6019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e237b3e
adding error for when := is called in not data.table aware enviroment
Mar 23, 2024
85c6ea2
added tests
Mar 24, 2024
d43a5b2
whitespace
MichaelChirico Mar 25, 2024
b0ca57a
Update R/data.table.R
Nj221102 Mar 25, 2024
cda1064
Update tests.Rraw
Nj221102 Mar 25, 2024
cb3a8a8
sprintf() won't coerce symbol->character, do it explicitly
MichaelChirico Mar 25, 2024
dadcd59
cleanup of test, better error message test
MichaelChirico Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions R/data.table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ replace_dot_alias = function(e) {
# the drop=NULL is to sink drop argument when dispatching to [.data.frame; using '...' stops test 147
if (!cedta()) {
# Fix for #500 (to do)
if (substitute(j) %iscall% c(":=", "let")) {
# Throw a specific error message
stopf("[ was called on a data.table in an environment that is not data.table-aware (i.e. cedta()), but '%s' was used, implying the owner of this call really intended for data.table methods to be called. See vignette('datatable-importing') for details on properly importing data.table.", as.character(substitute(j)[[1L]]))
}
Nargs = nargs() - (!missing(drop))
ans = if (Nargs<3L) { `[.data.frame`(x,i) } # drop ignored anyway by DF[i]
else if (missing(drop)) `[.data.frame`(x,i,j)
Expand Down
6 changes: 6 additions & 0 deletions inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18419,3 +18419,9 @@ test(2251.10, dim(fread(text, fill=TRUE)), c(9L, 9L))
test(2251.11, dim(fread(text, fill=7)), c(9L, 9L))
test(2251.12, dim(fread(text, fill=9)), c(9L, 9L))
test(2251.13, dim(fread(text, fill=20)), c(9L, 20L)) # clean up currently only kicks in if sep!=' '

.datatable.aware = FALSE
dt = data.table(a = 1L)
test(2252.1, dt[, b:=2L], error = "\\[ was called on a data.table.*not data.table-aware.*':='")
test(2252.2, dt[, let(b=2L)], error = "\\[ was called on a data.table.*not data.table-aware.*'let'")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same test is duplicated AFAIU - maybe the second case should be let. Also, we should unset the .datatable.aware variable. Otherwise, once we add more tests which expect to be a data.table aware package, it will fail and cause some confusion. Another alternative is to evaluate it in a different environment context but I am not sure if that is necessary.

The easiest way to do it is just remove the variable (e.g., rm(.datatable.aware)).

rm(.datatable.aware)
Loading