Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format-security compiler warnings #5774

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix format-security compiler warnings #5774

merged 2 commits into from
Dec 1, 2023

Conversation

MichaelChirico
Copy link
Member

For #5768

@jangorecki jangorecki added this to the 1.14.10 milestone Nov 30, 2023
@jangorecki
Copy link
Member

jangorecki commented Dec 1, 2023 •
edited
Loading 

sudo docker run -it --rm rocker/r-devel /bin/bash
mkdir -p ~/.R
echo 'CFLAGS=-Wformat-security' > ~/.R/Makevars
echo 'CXXFLAGS=-Wformat-security' >> ~/.R/Makevars

## optional
wget https://cran.r-project.org/src/contrib/data.table_1.14.8.tar.gz
RD CMD INSTALL data.table_1.14.8.tar.gz
# warnings reproduced

## PR
rm -fr format-security.zip data.table-format-security
wget https://github.com/Rdatatable/data.table/archive/refs/heads/format-security.zip
unzip format-security.zip
RD CMD build data.table-format-security --no-build-vignettes
RD CMD INSTALL data.table_1.14.9.tar.gz

jangorecki
jangorecki approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jangorecki jangorecki merged commit d0f233a into hotfix1.14.10 Dec 1, 2023
jangorecki pushed a commit that referenced this pull request Dec 2, 2023
@MichaelChirico @jangorecki
Fix format-security compiler warnings (#5774)
b6dec60
@jangorecki jangorecki deleted the format-security branch December 2, 2023 14:28
jangorecki added a commit that referenced this pull request Dec 2, 2023
@jangorecki @MichaelChirico
Fix format-security compiler warnings (#5774) (#5781)
a413d3c 
Co-authored-by: Michael Chirico <chiricom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jangorecki jangorecki jangorecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.10
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelChirico @jangorecki