Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear gcc warnings #5001

Merged
merged 1 commit into from
May 15, 2021
Merged

clear gcc warnings #5001

merged 1 commit into from
May 15, 2021

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented May 15, 2021

Follow up to #4289
Clear gcc warnings all like this one:

gcc -I"/usr/share/R/include" -DNDEBUG -fpic -fopenmp -std=c99 -O3 -pipe -Wall -pedantic -fno-common -c fifelse.c -o fifelse.o
fifelse.c: In function ‘fifelseR’:
fifelse.c:188:45: warning: ‘pa’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  188 |         if (!na_a) SET_VECTOR_ELT(ans, i, pa[i & amask]);

@mattdowle mattdowle added this to the 1.14.1 milestone May 15, 2021
@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #5001 (6bdbb73) into master (5cc3455) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5001   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          75       75           
  Lines       14775    14775           
=======================================
  Hits        14697    14697           
  Misses         78       78           
Impacted Files Coverage Δ
src/fifelse.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc3455...6bdbb73. Read the comment docs.

@mattdowle mattdowle merged commit 2da34fa into master May 15, 2021
@mattdowle mattdowle deleted the fifelse-followup branch May 15, 2021 09:50
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants