-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #4784 (standalone) #4901
fix #4784 (standalone) #4901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4901 +/- ##
==========================================
- Coverage 99.46% 99.46% -0.01%
==========================================
Files 75 75
Lines 14707 14705 -2
==========================================
- Hits 14629 14627 -2
Misses 78 78
Continue to review full report at Codecov.
|
Will close also #4816 |
I actually think the reduction in test coverage is a false positive, and anyway is tiny. Will this be accepted for merge? |
The reported reduction in test-coverage is only due to (justified) deletion of 2 covered lines: https://codecov.freshdesk.com/support/solutions/articles/43000634519-unexpected-drop-in-project-coverage-for-pull-request |
Hey. Is there anything more needed to have this merged? Thanks. |
@jangorecki @MichaelChirico Is there anything unclear, or otherwise missing, to merge this fix? |
Closes #4784 and #4816
Per maintainers' request - a PR containing just a single fix for 4784.