fsort segfault with clang-11 openmp #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N and OpenMP too now works for CRAN_Release.cmd
Codecov Report
@@ Coverage Diff @@
## master #4808 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 73 73
Lines 14557 14563 +6
=======================================
+ Hits 14481 14487 +6
Misses 76 76
Continue to review full report at Codecov.
|
|
diff coverage not 100% due to minor changes (e.g. j++ to ++j) on already uncovered lines. Need to revisit all uncovered lines anyway so not holding up this PR due to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4786
Supports OpenMP<4.5 by attempting regular dynamic schedule, checking if it is monotonic (probably is), and failing gracefully if not.
See comments in code.
By changing the #define in myomp.h to drop the monotonic: modifier (i.e. to be wrong), I confirmed the new check and error message works.