Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

na.omit respects missing nanotime values #4752

Merged
merged 4 commits into from
Aug 19, 2021
Merged

na.omit respects missing nanotime values #4752

merged 4 commits into from
Aug 19, 2021

Conversation

MichaelChirico
Copy link
Member

Closes #4744

As noted, complete.cases itself cannot be helped since it's a non-S3 stats function written in C & agnostic of bit64's NA value.

Nevertheless, with na.omit users can get the same desired behavior of DT[complete.cases(DT)] with na.omit(DT).

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #4752 (b465007) into master (51144d2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4752      +/-   ##
==========================================
+ Coverage   99.51%   99.54%   +0.02%     
==========================================
  Files          76       76              
  Lines       14695    14688       -7     
==========================================
- Hits        14624    14621       -3     
+ Misses         71       67       -4     
Impacted Files Coverage Δ
src/assign.c 100.00% <100.00%> (ø)
src/between.c 100.00% <100.00%> (ø)
src/coalesce.c 100.00% <100.00%> (ø)
src/fifelse.c 100.00% <100.00%> (ø)
src/nafill.c 100.00% <100.00%> (ø)
src/shift.c 100.00% <100.00%> (ø)
src/utils.c 97.52% <100.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51144d2...b465007. Read the comment docs.

@mattdowle mattdowle added this to the 1.14.1 milestone Aug 19, 2021
@mattdowle mattdowle merged commit c7b255e into master Aug 19, 2021
@mattdowle mattdowle deleted the na-omit-nanotime branch August 19, 2021 00:59
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

complete.cases does not work with nanotime
3 participants