Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message for #4214 #4343

Merged
merged 1 commit into from
Apr 15, 2021
Merged

improve error message for #4214 #4343

merged 1 commit into from
Apr 15, 2021

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Apr 2, 2020

improve error message for #4214

V = list(71L, c(71L, 132L), c(71L, 132L, 155L), 97L, 155L)
forder(V)
#Error in forderv(data, seq_along(data), sort = TRUE, retGrp = FALSE, order = if (decreasing) -asc else asc,  : 
#  Column 2 is length 2 which differs from length of column 1 (1), are you attempting to order by a list column?

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #4343 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4343   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          72       72           
  Lines       13916    13916           
=======================================
  Hits        13862    13862           
  Misses         54       54           
Impacted Files Coverage Δ
src/forder.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b1832...46d4951. Read the comment docs.

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mattdowle mattdowle added this to the 1.14.1 milestone Apr 15, 2021
@mattdowle mattdowle merged commit 54082e4 into master Apr 15, 2021
@mattdowle mattdowle deleted the order-list branch April 15, 2021 02:26
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants