Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

j auto-naming might delete an explicit NULL #4063

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Conversation

MichaelChirico
Copy link
Member

Closes #4061

explicit NULL was leading essentially to:

q[[n]] = NULL # <- deletes q[[n]]

and then the problem.

This issue was already handled in the if branch -- skip assignment if the object is NULL.

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #4063 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4063      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%     
=========================================
  Files          72      72              
  Lines       13674   13675       +1     
=========================================
+ Hits        13593   13594       +1     
  Misses         81      81
Impacted Files Coverage Δ
R/data.table.R 100% <100%> (ø) ⬆️
src/fread.c 99.44% <0%> (ø) ⬆️
src/fwrite.c 97.87% <0%> (ø) ⬆️
src/fsort.c 95.83% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d33704...f9c360e. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.7 milestone Nov 20, 2019
@mattdowle mattdowle merged commit 6f17d18 into master Nov 20, 2019
@MichaelChirico MichaelChirico deleted the autoname_j_followup branch November 20, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent j length error even with j returning NULL
2 participants