Formally remove relationship to reshape2 #3577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3549
A first pass at removing
reshape2
where possible.The
else
branches inmelt
anddcast
may or may not still be relevant... I checked the referenced package (edarf
) and there's no mention ofreshape2
in its currentDESCRIPTION
; anyway I imagine revdep checks for other packages will come back problematic.Still we should at least start the deprecation process of support in the next release... doesn't make much sense to me to maintain this code complexity for a deprecated package.