Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formally remove relationship to reshape2 #3577

Merged
merged 2 commits into from
May 22, 2019
Merged

Formally remove relationship to reshape2 #3577

merged 2 commits into from
May 22, 2019

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented May 22, 2019

Closes #3549
A first pass at removing reshape2 where possible.

The else branches in melt and dcast may or may not still be relevant... I checked the referenced package (edarf) and there's no mention of reshape2 in its current DESCRIPTION; anyway I imagine revdep checks for other packages will come back problematic.

Still we should at least start the deprecation process of support in the next release... doesn't make much sense to me to maintain this code complexity for a deprecated package.

@jangorecki
Copy link
Member

Instead of removing tests I would move them into integration tests, which are not being run on CRAN, but we do run them in CI.
https://github.com/Rdatatable/data.table/blob/master/inst/tests/tests-DESCRIPTION
https://github.com/Rdatatable/data.table/blob/master/inst/tests/other.Rraw

@MichaelChirico
Copy link
Member Author

@jangorecki no tests removed here. One test was edited since the error message had reshape2 in it (this was changed in fmelt.c)

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #3577 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3577      +/-   ##
==========================================
- Coverage   97.58%   97.58%   -0.01%     
==========================================
  Files          66       66              
  Lines       12695    12693       -2     
==========================================
- Hits        12389    12387       -2     
  Misses        306      306
Impacted Files Coverage Δ
R/fcast.R 99.4% <100%> (-0.01%) ⬇️
src/fmelt.c 88.63% <100%> (ø) ⬆️
R/fmelt.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6484781...38aab9d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #3577 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3577      +/-   ##
==========================================
- Coverage   97.58%   97.58%   -0.01%     
==========================================
  Files          66       66              
  Lines       12695    12693       -2     
==========================================
- Hits        12389    12387       -2     
  Misses        306      306
Impacted Files Coverage Δ
R/fcast.R 99.4% <100%> (-0.01%) ⬇️
src/fmelt.c 88.63% <100%> (ø) ⬆️
R/fmelt.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6484781...38aab9d. Read the comment docs.

@mattdowle mattdowle changed the title Closes #3549 -- formally remove relationship to reshape2 Formally remove relationship to reshape2 May 22, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone May 22, 2019
@mattdowle mattdowle merged commit 67199e2 into master May 22, 2019
@mattdowle mattdowle deleted the axe_reshape2 branch May 22, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completely axe reshape2 from code
3 participants