Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add %ilike% and %flike% filter operators #3552

Merged
merged 3 commits into from
May 16, 2019
Merged

Add %ilike% and %flike% filter operators #3552

merged 3 commits into from
May 16, 2019

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented May 9, 2019

Closes #3333

@andreasLD and @HughParsonage please have a look based on feedback in the issue thread. I don't think flike()/ilike() functions would be have much marginal value add to be worth adding; just %ilike% and %flike% should be sufficient.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #3552 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3552      +/-   ##
==========================================
+ Coverage   97.55%   97.55%   +<.01%     
==========================================
  Files          66       66              
  Lines       12664    12667       +3     
==========================================
+ Hits        12354    12357       +3     
  Misses        310      310
Impacted Files Coverage Δ
R/like.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58cf4a4...7b38488. Read the comment docs.

@mattdowle mattdowle changed the title Closes #3333 -- add %ilike% and %flike% filter operators Add %ilike% and %flike% filter operators May 16, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone May 16, 2019
@mattdowle mattdowle merged commit 0e5bf1e into master May 16, 2019
@mattdowle mattdowle deleted the ilike_flike branch May 16, 2019 20:58
@smingerson smingerson mentioned this pull request Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: split %like% into %like% and %rlike%
2 participants