Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setorder can keep keys in more cases #3458

Merged
merged 3 commits into from
Apr 2, 2019
Merged

setorder can keep keys in more cases #3458

merged 3 commits into from
Apr 2, 2019

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Mar 14, 2019 •
edited by mattdowle
Loading

Closes #3456

@codecov
Copy link

codecov bot commented Mar 14, 2019 •
edited
Loading

Codecov Report

Merging #3458 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3458      +/-   ##
==========================================
+ Coverage   96.62%   96.62%   +<.01%     
==========================================
  Files          65       65              
  Lines       12250    12255       +5     
==========================================
+ Hits        11836    11841       +5     
  Misses        414      414
Impacted Files Coverage Δ
R/setkey.R 98.27% <100%> (+0.01%) ⬆️
src/gsumm.c 96.74% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c3b27...4d4fd86. Read the comment docs.

jangorecki
jangorecki approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdowle mattdowle added this to the 1.12.4 milestone Apr 1, 2019
@mattdowle mattdowle changed the title Closes #3456 -- setorder is more careful about resetting keys setorder can keep keys in more cases Apr 1, 2019
@mattdowle mattdowle merged commit 8e8db7c into master Apr 2, 2019
@mattdowle mattdowle deleted the setorder_setkey branch April 2, 2019 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jangorecki jangorecki jangorecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelChirico @jangorecki @mattdowle