Add helpful diagnostic error to setDT #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3122 +/- ##
==========================================
+ Coverage 92.34% 92.34% +<.01%
==========================================
Files 61 61
Lines 11585 11590 +5
==========================================
+ Hits 10698 10703 +5
Misses 887 887
Continue to review full report at Codecov.
|
R/data.table.R
Outdated
| @@ -2752,8 +2752,15 @@ setDT <- function(x, keep.rownames=FALSE, key=NULL, check.names=FALSE) { | |||
| } | |||
| n = vapply(x, length, 0L) | |||
| mn = max(n) | |||
| if (any(n<mn)) | |||
| stop("All elements in argument 'x' to 'setDT' must be of same length") | |||
| if (any(idx <- n<mn)) { | |||
There was a problem hiding this comment.
Suggested change
| if (any(idx <- n<mn)) { | |
| if (min(n) < mn) | |
| idx <- n < mn |
(faster)
There was a problem hiding this comment.
@HughParsonage nice. I guess n_rng = range(n) even faster then...
jangorecki
reviewed
Oct 20, 2018
R/utils.R
Outdated
| # (common aggregation method for error messages) | ||
| brackify = function(x) { | ||
| # arbitrary cutoff | ||
| if (length(x) > 10L) x = c(x[1:10], '...') |
There was a problem hiding this comment.
This is very nice you handle that already but could also be tested
There was a problem hiding this comment.
@jangorecki see #3117
max(n) already known
ab0729d to
c502595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3121