Closes #2007 by adding a test to ensure explicit select = NULL works

[MichaelChirico]

@st-pasha Alternatively, we could just remove the select = NULL default and continue with the code as it was before. I think this is preferred as it allows users to have a value to set explicitly in dynamic use cases.

[mattdowle]

@MichaelChirico The test has a 2 that should be 2L to pass, iiuc.

[codecov-io]

Codecov Report

Merging #2424 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2424      +/-   ##
==========================================
+ Coverage   91.24%   91.26%   +0.01%     
==========================================
  Files          62       62              
  Lines       12027    12027              
==========================================
+ Hits        10974    10976       +2     
+ Misses       1053     1051       -2

Impacted Files	Coverage Δ
R/fread.R	94.61% <100%> (ø)	⬆️
src/forder.c	93.94% <0%> (+0.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b12da9...94ba1f3. Read the comment docs.

[mattdowle]

Btw @MichaelChirico, feel free to create branches directly in root now that you're a project member. That way we can commit to each other's branches if need be.

[MichaelChirico]

cool, will do

…

On Oct 19, 2017 9:11 AM, "Matt Dowle" ***@***.***> wrote: Btw @MichaelChirico <https://github.com/michaelchirico>, feel free to create branches directly in root now that you're a project member. That way we can commit to each other's branches if need be. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2424 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQQdV3DjNQ3H_HkzrnRD8wJGidF6LDJks5stqHWgaJpZM4P7prE> .

[romanzenka]

@MichaelChirico Please do not switch to more 'missing' tests and arguments without default values.
I am wrapping fread in my own function and it is a pain to pass over "missing" parameters in a function call. Much better provide a default that is NULL and then test for is.null.