Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip final 0x1A character in the input file, if found. #2253

Merged
merged 4 commits into from
Jul 7, 2017
Merged

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Jul 7, 2017

Closes #1612

@codecov-io
Copy link

codecov-io commented Jul 7, 2017

Codecov Report

Merging #2253 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
+ Coverage   90.72%   90.84%   +0.12%     
==========================================
  Files          59       59              
  Lines       11509    11526      +17     
==========================================
+ Hits        10441    10471      +30     
+ Misses       1068     1055      -13
Impacted Files Coverage Δ
src/fread.c 93.45% <100%> (+0.11%) ⬆️
src/forder.c 94.47% <0%> (+0.78%) ⬆️
src/bmerge.c 96.92% <0%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f29b60...56d54dd. Read the comment docs.

@mattdowle mattdowle merged commit bef5403 into master Jul 7, 2017
@mattdowle mattdowle deleted the fread_0x1A branch July 7, 2017 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants