Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stringsAsFactors=.2 is undocumented #4706

Closed
MichaelChirico opened this issue Sep 15, 2020 · 3 comments
Closed

stringsAsFactors=.2 is undocumented #4706

MichaelChirico opened this issue Sep 15, 2020 · 3 comments
Labels
beginner-task documentation fread
Milestone
1.15.0

Comments

@MichaelChirico
Copy link
Member

Follow-up to #2025 -- we mentioned the change in NEWS but nothing in fread.Rd
@markderry
Copy link
Contributor

I have updated the documentation and I am wondering if the following is still required for a PR?

  • A new test
  • A news entry

markderry pushed a commit to markderry/data.table that referenced this issue Oct 9, 2020
fix Rdatatable#4706
c96c810 
Added documentation for stringsAsFactors
@MichaelChirico
Copy link
Member Author

no test, but you can add a NEWS entry and please cite yourself for the fix. thanks!

markderry pushed a commit to markderry/data.table that referenced this issue Oct 9, 2020
Close Rdatatable#4706
0bc9a76 
Added documentation for stringsAsFactors
@markderry markderry mentioned this issue Oct 9, 2020
Merged
@mattdowle mattdowle added this to the 1.14.1 milestone Apr 14, 2021
@mattdowle
Copy link
Member

Closed by Mark's #4745. Thanks!

@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-task documentation fread
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
4 participants
@mattdowle @markderry @jangorecki @MichaelChirico