Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-Forge #5758] unique and duplicated should also warn on columns with mixed encodings. #469

Open
arunsrinivasan opened this issue Jun 8, 2014 · 3 comments
Open

[R-Forge #5758] unique and duplicated should also warn on columns with mixed encodings. #469

arunsrinivasan opened this issue Jun 8, 2014 · 3 comments
Assignees
@arunsrinivasan
Labels
bug

Comments

@arunsrinivasan
Copy link
Member

Submitted by: Arun ; Assigned to: Nobody; R-Forge link

Sigh! It just seems not possible to put this (mixed) encoding issue to rest. As reported here on SO.
@arunsrinivasan arunsrinivasan added this to the v1.9.4 milestone Jun 19, 2014
@arunsrinivasan arunsrinivasan modified the milestones: 2.0.1, v2.0 Sep 6, 2014
@arunsrinivasan arunsrinivasan modified the milestones: v1.9.6, v1.9.8 Oct 10, 2014
arunsrinivasan added a commit that referenced this issue Jan 20, 2016
@arunsrinivasan
Handles mixed encodings by ensuring proper encodings upfront. Closes #66
c2c8387 
, #69, #469 and #1293.

Hopefully, this handles things nicely.
@arunsrinivasan arunsrinivasan self-assigned this Jan 20, 2016
arunsrinivasan added a commit that referenced this issue Jan 27, 2016
@arunsrinivasan
Better fix for encoding issues, #66, #69, #469, #1293.
03cd45f 
When marked non-utf8 encodings are detected, they are internally converted to utf-8 before comparing.
arunsrinivasan added a commit that referenced this issue Feb 8, 2016
@arunsrinivasan
Upate NEWS for encoding issues following better fix, #69, #469, #1293.
e75162b
@mattdowle
Copy link
Member

mattdowle commented Nov 23, 2016 •
edited
Loading

Unfortunately this added encoding into tests.Rraw which fails the tests in CRAN_Release.cmd because it fails on CRAN when it gets to Mac if I remember correctly, which is why I put the grep into CRAN_Release.cmd. I'll have to take the test out.

@mattdowle mattdowle reopened this Nov 23, 2016
mattdowle added a commit that referenced this issue Nov 23, 2016
@mattdowle
Encoding characters removed from tests.Rraw. They fail the grep in CR…
670c476 
…AN_Release.cmd because they've failed on CRAN before. Reopened issue #469 and postponed it to v1.9.10 to resinstate these tests into DtNonAsciiTests package. Those characters cannot even be commented out because their presence in the file causes the CRAN issue. There probably is a better solution but I do not know it.
@mattdowle mattdowle modified the milestones: v1.9.10, v1.9.8 Nov 23, 2016
@jangorecki
Copy link
Member

afaiu those tests could goes under #1343?

@arunsrinivasan
Copy link
Member Author

@mattdowle okay. What's the way to add tests for encoding related issues then? The issue seems fixed, just trying to wrap up the test so it can be closed.

@mattdowle mattdowle removed this from the Candidate milestone May 10, 2018
@jangorecki jangorecki removed the High label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunsrinivasan arunsrinivasan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattdowle @arunsrinivasan @jangorecki