Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename alloc.col to set.alloc.col #3475

Closed
jangorecki opened this issue Mar 27, 2019 · 2 comments · Fixed by #3792
Closed

rename alloc.col to set.alloc.col #3475

jangorecki opened this issue Mar 27, 2019 · 2 comments · Fixed by #3792
Assignees
@jangorecki
Labels
consistency
Milestone
1.12.4

Comments

@jangorecki
Copy link
Member

for consistency
@MichaelChirico
Copy link
Member

If we're going to change, I wouldn't use set.alloc.col which sounds odd.

set_allocated_columns or the like would be more expressive & help get at what it's doing

@shrektan
Copy link
Member

A little off-topic, but I really wish one day there's a way to auto set alloc.col() to the data.table objects from RDS files...

@jangorecki jangorecki added this to the 1.12.4 milestone Aug 27, 2019
@jangorecki jangorecki self-assigned this Aug 27, 2019
jangorecki added a commit that referenced this issue Aug 27, 2019
@jangorecki
alloc.col now also as setalloccol, closes #3475
94ff977
@jangorecki jangorecki mentioned this issue Aug 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jangorecki jangorecki

Labels
consistency
Projects
None yet
Milestone
1.12.4
Development

Successfully merging a pull request may close this issue.

alloc.col now also as setalloccol Rdatatable/data.table
3 participants
@jangorecki @MichaelChirico @shrektan