setindexv could accept list of characters to create multiple indices

[jangorecki]

It could be internally optimized for speed but for now it will be enough to run in loop.
API to create index on a field and second index on a, b fields:

setindexv(DT, list("a",c("a","b"))

[MichaelChirico]

I'm just about done writing this.... but I'm thinking, is this really any more convenient than sapply(list('a', c('a', 'b')), setindexv, x = DT)?

i have the following so far:

setindexv <- function(x, cols, verbose=getOption("datatable.verbose")) {
  if (is.list(cols)) {
    sapply(cols, function(index_i) setkeyv(x, index_i, verbose, physical=FALSE))
  } else {
    setkeyv(x, cols, verbose, physical=FALSE)
  }
}

[jangorecki]

Single DT should be returned from setindexv, no matter if we set one index or many. A little more convenient :) and we are going to use same API in fread already. It would be awkward if user will learn setting up index on fread and then would be surprised it is not working with setindexv. If you are deving this why no self assign issue?

[MichaelChirico]

I see. so will revert to loop as well. thanks

…

On Thu, Mar 29, 2018, 8:05 PM Jan Gorecki ***@***.***> wrote: Single DT should be returned from setindexv, not matter if we set one index or many. A little more convenient :) and we are going to use same API in fread already. It would be awkward if user will learn setting up index on fread and then would be surprised it is not working with setindexv. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2695 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQQdXmICLPEt0lubalfPOYETijzx2nsks5tjM4kgaJpZM4S2bRf> .