Update error message for ImportErrors #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiswells97
reviewed
Oct 18, 2024
CHANGELOG.md
Outdated
| ### Changed | ||
|
|
||
| - Updated the ImportErrors message | ||
| - In ErrorMassege component added the way to display html elements in string |
There was a problem hiding this comment.
Slight typo in ErrorMessage
loiswells97
reviewed
Oct 18, 2024
Comment on lines
307
to
308
| const articleLink = | ||
| "https://help.editor.raspberrypi.org/hc/en-us/articles/30841379339924-What-Python-libraries-are-available-in-the-Code-Editor"; |
There was a problem hiding this comment.
This is probably fine for now, but I'm wondering whether in the future we might want to link this off to different locales with translations of the article 🤔
There was a problem hiding this comment.
Thanks @loiswells97 for you review!!
Locales were added
There was a problem hiding this comment.
This was just a thought for the future sorry, not something we want right now... I just checked and it looks like it's only the en-us locale that exists on the help site for now, en-GB for example gives a 404
…ithub.com/RaspberryPiFoundation/editor-ui into 309-update-error-message-for-importerrors
loiswells97
approved these changes
Oct 21, 2024
Merged
loiswells97
added a commit
that referenced
this pull request
Oct 22, 2024
## [0.28.0] - 2024-10-22 ### Added - PyodideWorker setup for the editor (#1104) - Enabling `pyodide` support in the web component (#1090) - `Pyodide` `matplotlib` support (#1087) - Tests for running simple programs in `pyodide` and `skulpt` (#1100) - Fall back to `skulpt` if the host is not `crossOriginIsolated` (#1107) - `Pyodide` `seaborn` support (#1106) - `Pyodide` module caching (#1113) ### Changed - Upgrade to `webpack 5` (#1096) - Bump `pyodide` to `v0.26.2` (#1098) - Updated the ImportErrors message (#1105) - In ErrorMessage component added the way to display html elements in string (#1105) ### Fixed - Dynamic runner switching with more than one `python` file (#1097) - Pyodide running the correct file (`main.py`) when there are multiple `python` files (#1097) - Build to include public files (#1112) - Persisting choice of tabbed/split view when running `python` code (#1114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #309