-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a schema and a writer for the 2.0 Core training data #6396
Conversation
0f6d0de
to
3bb3c9b
Compare
def process_story_step(self, story_step: StoryStep) -> Optional[OrderedDict]: | ||
|
||
if self.story_contains_forms(story_step): | ||
raise_warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we print them somewhere or dump them to a separate file or something? anything that makes it easier to transition if the user was using forms the old way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great idea! I'll make a note to do that later. Currently look a little bit timely because we parse MD line by line, and requires me to know the code better, so not easy to implement before tomorrow.
|
||
if self.story_contains_forms(story_step): | ||
raise_warning( | ||
f'File "{self.target}" contains a story "{story_step.block_name}" ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if a user annotates a conversation that has a form in rasa x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation of writer is done with "old MD -> YAML" in mind, so neither forms nor rules are supported now, also as a first implementation the Rasa X doesn't have an access to this writer at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have noted that in the Issue description 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍 I have nothing important to add, only small details.
b4d5f7f
to
1c6a273
Compare
1c6a273
to
d1f1eb9
Compare
d1f1eb9
to
4326797
Compare
Closes #6374
Proposed changes:
slot_was_set
eventStatus (please check what you already did):
black
(please check Readme for instructions)