Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated stack level for FutureWarnings #5861

Merged
merged 13 commits into from
May 26, 2020
Merged

Updated stack level for FutureWarnings #5861

merged 13 commits into from
May 26, 2020

Conversation

Archish27
Copy link
Contributor

@Archish27 Archish27 commented May 20, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Archish27 Archish27 closed this May 20, 2020
@Archish27 Archish27 reopened this May 20, 2020
@Archish27 Archish27 changed the title Updated stack level & added test Updated stack level for FutureWarnings May 20, 2020
@Archish27 Archish27 mentioned this pull request May 20, 2020
Closed
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @Ghostvv will take a look at it as soon as possible ✨

@sara-tagger sara-tagger requested a review from Ghostvv May 20, 2020 09:22
@akelad akelad requested review from ricwo and removed request for Ghostvv May 20, 2020 11:32
ricwo
ricwo suggested changes May 25, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into this 👍

@Archish27
Copy link
Contributor Author

@ricwo Can you help me with check of merge-pal ? It breaks. I have generated token.

ricwo
ricwo approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Archish27
Copy link
Contributor Author

@ricwo Can help with this error ?

@ricwo ricwo merged commit 3cd6550 into RasaHQ:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Future warnings have strange return statements in them
4 participants
@Archish27 @sara-tagger @ricwo @rasabot