Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: one word two entity labels #5476

Merged
merged 11 commits into from
Mar 25, 2020
Merged

Fix bug: one word two entity labels #5476

merged 11 commits into from
Mar 25, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Mar 24, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from dakshvar22 March 24, 2020 12:02
@dakshvar22
Copy link
Contributor

@tabergma When do we not have a confidence attached to the entity?

@tabergma
Copy link
Contributor Author

We have it for CRFEntityExtractor, but we don't have it for DIETClassifier.

@dakshvar22
Copy link
Contributor

But then shouldn't we attach it? If there is no confidence and the word is broken into two tokens, discarding the entities for both tokens is a bit drastic, no?

@tabergma
Copy link
Contributor Author

tabergma commented Mar 24, 2020 •
edited
Loading

Yes, but would tackle that in a different PR. Will create an issue for it.
EDIT: #5481

@tabergma tabergma requested a review from dakshvar22 March 25, 2020 08:56
dakshvar22
dakshvar22 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding comments 👍

@tabergma tabergma merged commit 99cff55 into master Mar 25, 2020
@tabergma tabergma deleted the bug-one-word-two-labels branch March 25, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakshvar22 dakshvar22 dakshvar22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One word two entity labels
2 participants
@tabergma @dakshvar22