Enable providing several components of the same type in nlu pipeline #1693

Ghostvv · 2019-02-05T15:35:44Z

Proposed changes:

finish WIP make possible to load several components with the same name #1546
create, load and persist components based on their index in nlu pipeline
fixes: RasaHQ/roadmap#325

Status (please check what you already did):

made PR ready for code review
added some tests for the functionality
updated the documentation
updated the changelog

tmbo

left a couple comments: in general we should make the persistence of policies and components very similar (e.g. right now, every policy gets its own directory wheras for nlu we use file name prefix)

rasa_nlu/classifiers/embedding_intent_classifier.py

rasa_nlu/components.py

Ghostvv · 2019-02-06T10:46:14Z

core persistence doesn't have metadata persisted

tmbo · 2019-02-06T10:51:23Z

yes I know, every policy does that on its own (which I think might also make sense, because the policies are independent so you can actually train them outside of core and persist them, wheras that doesn't make sense for the components in the nlu pipeline)

Ghostvv · 2019-02-06T10:54:49Z

True, so are we going for folders? Because folders also kind of imply independence, while here only crf and intent classifier are independent

tmbo

great job and a lot of work 🚀 couple type and style comments and one additional thing I noticed:

mitie_utils and spacy_utils still have the name property

rasa_nlu/classifiers/embedding_intent_classifier.py

rasa_nlu/classifiers/mitie_intent_classifier.py

rasa_nlu/components.py

rasa_nlu/model.py

rasa_nlu/utils/__init__.py

rasa_nlu/utils/spacy_utils.py

tests/base/test_components.py

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

codeclimate · 2019-02-26T14:44:15Z

Code Climate has analyzed commit 671f2f3 and detected 16 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	16

View more on Code Climate.

tmbo

looks great, some small comments and then we are ready to merge 🚀

rasa_nlu/classifiers/embedding_intent_classifier.py

rasa_nlu/components.py

rasa_nlu/registry.py

tmbo · 2019-02-27T15:43:58Z

@Ghostvv please also make sure to increase the version in the version py and change the min compatible version in the constants.py

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Ghostvv · 2019-02-27T16:10:17Z

@tmbo what do you mean with the version? Do we want to release current master 0.15 before this one? and this one should be 0.16?

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

tmbo · 2019-02-27T16:19:19Z

No I mean increasing the version to 0.15.0a2 and setting the minimum compatible version to that as well, because models with earlier versions can not be loaded anymore, right?

Ghostvv · 2019-02-27T16:53:18Z

@tmbo added changes according to your comments, could you please take a look? Particularly whether migration guide is understandable

tmbo · 2019-02-27T16:55:20Z

looks good

Co-authored-by: Jason Song <i@wolfogre.com>

Ghostvv added 2 commits February 5, 2019 16:33

create nlu pipeline based on the index instead of component name

e70d7bc

Merge branch 'master' into fix-component-config-2

9f1dd0a

Ghostvv requested a review from tmbo February 5, 2019 15:35

Ghostvv added 2 commits February 5, 2019 17:46

fix comments

ddf3efe

fix comments

b3e36ba

tmbo reviewed Feb 6, 2019

View reviewed changes

rasa_nlu/classifiers/embedding_intent_classifier.py Outdated Show resolved Hide resolved

rasa_nlu/components.py Outdated Show resolved Hide resolved

rasa_nlu/components.py Outdated Show resolved Hide resolved

Ghostvv added 2 commits February 20, 2019 11:18

Merge branch 'master' into fix-component-config-2

890eadf

pass component config instead of index

224b11f

tmbo previously approved these changes Feb 22, 2019

View reviewed changes

tmbo and others added 18 commits February 22, 2019 18:06

Update rasa_nlu/classifiers/embedding_intent_classifier.py

c88b40f

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/classifiers/mitie_intent_classifier.py

a9e4044

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/components.py

de6aba6

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/components.py

889778e

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/components.py

c88dc1f

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/utils/__init__.py

c72663d

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/extractors/duckling_http_extractor.py

e38be86

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/extractors/duckling_http_extractor.py

5e5a4c0

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/extractors/entity_synonyms.py

48cbd28

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/extractors/mitie_entity_extractor.py

77ddc51

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/featurizers/count_vectors_featurizer.py

55b0fd3

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/featurizers/ngram_featurizer.py

0466230

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/featurizers/regex_featurizer.py

5f8f1ef

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/registry.py

785169a

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/registry.py

4487543

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/tokenizers/jieba_tokenizer.py

28c9c5b

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/utils/mitie_utils.py

33a082b

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/utils/mitie_utils.py

afa8875

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Ghostvv added 3 commits February 25, 2019 22:01

Merge branch 'master' into fix-component-config-2

b728a10

Merge branch 'master' into fix-component-config-2

33e1c21

add old style names for compatibility

46f9537

Ghostvv added 3 commits February 26, 2019 17:17

update changelog, remove test_models/ dir

0d2562e

rename components in docs and comments

9267b92

merge master

7b34a44

tmbo self-requested a review February 27, 2019 10:42

Ghostvv added 2 commits February 27, 2019 15:50

return test_model_dir

b7a2288

Merge branch 'master' into fix-component-config-2

5e1f5f4

tmbo approved these changes Feb 27, 2019

View reviewed changes

Ghostvv and others added 3 commits February 27, 2019 17:07

convert name() to class property

835b6d9

Update rasa_nlu/registry.py

f49e38c

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

Update rasa_nlu/registry.py

1728c67

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

tmbo and others added 2 commits February 27, 2019 17:10

Update rasa_nlu/registry.py

4629f51

Co-Authored-By: Ghostvv <mr.voov@gmail.com>

add deprecation warninig for old style names

f93f044

Ghostvv added 3 commits February 27, 2019 17:27

change version and min compatible version

8903309

update changelog

d5754e4

update migration guide

3649602

Ghostvv added 3 commits February 27, 2019 18:00

add warning to migrations

9977f87

fix compatibility tests

9a6125b

remove comma

671f2f3

Ghostvv merged commit fff4826 into master Feb 28, 2019

Ghostvv deleted the fix-component-config-2 branch February 28, 2019 09:47

taytzehao pushed a commit to taytzehao/rasa that referenced this pull request Jul 14, 2023

typo: fix expression of warning message on macOS (RasaHQ#1693)

d970056

Co-authored-by: Jason Song <i@wolfogre.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable providing several components of the same type in nlu pipeline #1693

Enable providing several components of the same type in nlu pipeline #1693

Ghostvv commented Feb 5, 2019 •

edited

Loading

tmbo left a comment

Ghostvv commented Feb 6, 2019

tmbo commented Feb 6, 2019

Ghostvv commented Feb 6, 2019 •

edited

Loading

tmbo left a comment

codeclimate bot commented Feb 26, 2019 •

edited

Loading

tmbo left a comment

tmbo commented Feb 27, 2019

Ghostvv commented Feb 27, 2019

tmbo commented Feb 27, 2019

Ghostvv commented Feb 27, 2019

tmbo commented Feb 27, 2019

Enable providing several components of the same type in nlu pipeline #1693

Enable providing several components of the same type in nlu pipeline #1693

Conversation

Ghostvv commented Feb 5, 2019 • edited Loading

tmbo left a comment

Choose a reason for hiding this comment

Ghostvv commented Feb 6, 2019

tmbo commented Feb 6, 2019

Ghostvv commented Feb 6, 2019 • edited Loading

tmbo left a comment

Choose a reason for hiding this comment

codeclimate bot commented Feb 26, 2019 • edited Loading

tmbo left a comment

Choose a reason for hiding this comment

tmbo commented Feb 27, 2019

Ghostvv commented Feb 27, 2019

tmbo commented Feb 27, 2019

Ghostvv commented Feb 27, 2019

tmbo commented Feb 27, 2019

Ghostvv commented Feb 5, 2019 •

edited

Loading

Ghostvv commented Feb 6, 2019 •

edited

Loading

codeclimate bot commented Feb 26, 2019 •

edited

Loading