Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzer to vectorizer #1547

Merged
merged 20 commits into from
Dec 12, 2018
Merged

Add analyzer to vectorizer #1547

merged 20 commits into from
Dec 12, 2018

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Nov 22, 2018

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@Ghostvv
Copy link
Contributor Author

Ghostvv commented Nov 22, 2018

previous PR: #1540

@amn41
Copy link
Contributor

amn41 commented Nov 27, 2018

@Ghostvv I would argue this is not blocked by #1546 because this is useful on its own (I am using it) - wdyt?

@Ghostvv Ghostvv requested a review from tmbo November 29, 2018 15:21
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - cool functionality 💯 some style suggestions and we are ready to merge.

@jstriebel
Copy link
Contributor

It would be great if you could add a prerelease once this is merged, as it is not possible to specify the embedding parameters in a config currently (see #1555 for details).

@jstriebel
Copy link
Contributor

Any news on this PR? Can I help out with something?

@Ghostvv Ghostvv deleted the add-analyzer branch December 12, 2018 13:34
taytzehao pushed a commit to taytzehao/rasa that referenced this pull request Jul 14, 2023
Use the -s (silent) flag so curl does not pass metainformation like
downloadspeed etc to bash.

Co-authored-by: ChristopherHX <christopher.homberger@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants