-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyzer to vectorizer #1547
Conversation
previous PR: #1540 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great - cool functionality 💯 some style suggestions and we are ready to merge.
It would be great if you could add a prerelease once this is merged, as it is not possible to specify the embedding parameters in a config currently (see #1555 for details). |
Any news on this PR? Can I help out with something? |
Use the -s (silent) flag so curl does not pass metainformation like downloadspeed etc to bash. Co-authored-by: ChristopherHX <christopher.homberger@web.de>
Proposed changes:
analyzer
argument to CountVectorsFeaturizerStatus (please check what you already did):