Check for PVC label selector conflicts against the secondary cluster.

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>

internal/controller/vrg_volrep.go

@@ -182,6 +182,17 @@ func (v *VRGInstance) reconcileVolRepsAsSecondary() bool {
 		v.pvcStatusDeleteIfPresent(pvc.Namespace, pvc.Name, log)
 	}
 
+	// Ensure that no PVC on the secondary cluster matches the label selector.
+	// This runs after all protected PVCs have been safely cleaned up in the previous step.
+	if !requeue && len(v.volRepPVCs) > 0 {
+		v.log.Info("No PVC on the secondary should match the label selector")
+		requeue = true
+	}
+
+	if !requeue {
+		v.log.Info("Successfully reconciled VolRep as Secondary")
+	}
+
 	return requeue
 }
 

internal/controller/vrg_volsync.go

@@ -239,6 +239,15 @@ func (v *VRGInstance) reconcileVolSyncAsSecondary() bool {
 
 		v.instance.Status.ProtectedPVCs = v.instance.Status.ProtectedPVCs[:idx]
 		v.log.Info("Protected PVCs left", "ProtectedPVCs", v.instance.Status.ProtectedPVCs)
+	} else {
+		for _, rdSpec := range v.instance.Spec.VolSync.RDSpec {
+			for _, pvc := range v.volSyncPVCs {
+				if pvc.GetName() != rdSpec.ProtectedPVC.Name {
+					v.log.Info("A PVC that is not a replication destination should not match the label selector.")
+					return true
+				}
+			}
+		}
 	}
 
 	// Reset status finalsync flags and condition