Make logout go to the origin page

Raku · Nov 7, 2023 · 9851ff6 · 9851ff6
1 parent 29a4d77
commit 9851ff6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/lib/Routes.rakumod b/lib/Routes.rakumod
@@ -57,13 +57,17 @@ sub routes(CITestSetManager $tsm, SourceArchiveCreator $sac, GitHubInterface $gi
         }
 
         sub gen-login-data($origin) {
-            my $url-data = $github-interface.oauth-step-one-url(encode-percents($origin));
-            return $url-data;
+            return {
+                login-url => $github-interface.oauth-step-one-url(encode-percents($origin)),
+                :$origin,
+            }
         }
 
         post -> "logout" {
-            set-cookie $jwt-gh-cookie-name, "", Max-Age => 0;
-            redirect :see-other, "/";
+            request-body -> (:$origin!) {
+                set-cookie $jwt-gh-cookie-name, "", Max-Age => 0;
+                redirect :see-other, $origin;
+            }
         }
 
         get -> "gh-oauth-callback", :$code, :$state {

diff --git a/resources/templates/login.crotmp b/resources/templates/login.crotmp
@@ -3,12 +3,13 @@
 <?$logged-in>
   <span class="username"><$name></span>
   <form action="<$logout-url>" method="post">
+    <input type="hidden" name="origin" value="<$login-data.origin>">
     <input type="submit" value="Logout">
   </form>
 </?>
 <!>
-  <form action="<$login-data.url>" method="get">
-    <@$login-data.query-params>
+  <form action="<$login-data.login-url.url>" method="get">
+    <@$login-data.login-url.query-params>
     <input type="hidden" name="<.key>" value="<.value>">
     </@>
     <input type="submit" value="Login">