Skip to content

Commit

Permalink
Fix updating non-completed check runs
Browse files Browse the repository at this point in the history
An optional parameter with a `:D` constraint makes no sense, as the
parameter receives the type object if left empty and then fails the
definedness constraint.
  • Loading branch information
patrickbkr committed May 5, 2023
1 parent 29bce4a commit 1773d16
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/GitHubInterface.rakumod
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ method create-check-run(:$owner!, :$repo!, :$name!, :$sha!, :$url!, Str() :$id!,
return $data<id>;
}

method update-check-run(:$owner!, :$repo!, Str() :$check-run-id!, :$status!, DateTime:D :$completed-at, :$conclusion) {
method update-check-run(:$owner!, :$repo!, Str() :$check-run-id!, :$status!, DateTime :$completed-at, :$conclusion) {
self!validate($!gh.checks-runs.update($owner, $repo, $check-run-id,
:$status,
|($completed-at ?? completed-at => $completed-at.Str !! {}),
Expand Down

0 comments on commit 1773d16

Please sign in to comment.