sea: expose only isExperimentalSeaWarningNeeded to JS from the binding

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen · Apr 26, 2023 · fa9df64 · fa9df64
1 parent ce5e999
commit fa9df64
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/lib/internal/main/embedding.js b/lib/internal/main/embedding.js
@@ -3,15 +3,15 @@ const {
   prepareMainThreadExecution,
   markBootstrapComplete,
 } = require('internal/process/pre_execution');
-const { isExperimentalSeaWarningDisabled, isSea } = internalBinding('sea');
+const { isExperimentalSeaWarningNeeded } = internalBinding('sea');
 const { emitExperimentalWarning } = require('internal/util');
 const { embedderRequire, embedderRunCjs } = require('internal/util/embedding');
 const { getEmbedderEntryFunction } = internalBinding('mksnapshot');
 
 prepareMainThreadExecution(false, true);
 markBootstrapComplete();
 
-if (isSea() && !isExperimentalSeaWarningDisabled()) {
+if (isExperimentalSeaWarningNeeded()) {
   emitExperimentalWarning('Single executable application');
 }
 

diff --git a/src/node_sea.cc b/src/node_sea.cc
@@ -105,13 +105,9 @@ bool IsSingleExecutable() {
   return postject_has_resource();
 }
 
-void IsSingleExecutable(const FunctionCallbackInfo<Value>& args) {
-  args.GetReturnValue().Set(IsSingleExecutable());
-}
-
-void IsExperimentalSeaWarningDisabled(const FunctionCallbackInfo<Value>& args) {
+void IsExperimentalSeaWarningNeeded(const FunctionCallbackInfo<Value>& args) {
   SeaResource sea_resource = FindSingleExecutableResource();
-  args.GetReturnValue().Set(static_cast<bool>(
+  args.GetReturnValue().Set(!static_cast<bool>(
       sea_resource.flags & SeaFlags::kDisableExperimentalSeaWarning));
 }
 
@@ -243,16 +239,14 @@ void Initialize(Local<Object> target,
                 Local<Value> unused,
                 Local<Context> context,
                 void* priv) {
-  SetMethod(context, target, "isSea", IsSingleExecutable);
   SetMethod(context,
             target,
-            "isExperimentalSeaWarningDisabled",
-            IsExperimentalSeaWarningDisabled);
+            "isExperimentalSeaWarningNeeded",
+            IsExperimentalSeaWarningNeeded);
 }
 
 void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
-  registry->Register(IsSingleExecutable);
-  registry->Register(IsExperimentalSeaWarningDisabled);
+  registry->Register(IsExperimentalSeaWarningNeeded);
 }
 
 }  // namespace sea